Default Win32 transport to WinHTTP with safe cancellation - #1520

Open

bmehta001 wants to merge 125 commits into

microsoft:mainfrom

bmehta001:bhamehta/winhttp-default-windows-transport

Commits on Jun 10, 2026

fix: guard HAVE_MAT_LIVEEVENTINSPECTOR/PRIVACYGUARD against redefinition

bmehta001
and
Copilot
committed
7b43dd4

Commits on Jun 11, 2026

fix: prevent EDEADLK self-join in ~CurlHttpOperation on async-thread destruction

bmehta001
and
Copilot
committed
fc7375a
Merge branch 'main' into bhamehta/fix-curl-async-self-join
bmehta001
authored
e76fabf

Commits on Jun 13, 2026

Make ~CurlHttpOperation detach conditional on self-join (fix UAF regression)

bmehta001
and
Copilot
committed
3554d8d
Address Copilot round 2 on #1481: include <new>, handle nothrow-new failure

bmehta001
and
Copilot
committed
b10fa89
Address Copilot round 3 on #1481: avoid atomic<thread::id>, fix lifetime comments

bmehta001
and
Copilot
committed
3dda53b
Address Copilot round 4 on #1481: precise self-join comment, reset flag on reuse

bmehta001
and
Copilot
committed
7e22ed2

Commits on Jun 30, 2026

Merge branch 'main' into bhamehta/fix-curl-async-self-join
bmehta001
authored
dcbc2a2

Commits on Jul 8, 2026

Commits on Jul 9, 2026

Address Copilot round 5 on #1481: <limits> include, broaden thread-start catch, fix test comment

bmehta001
and
Copilot
committed
f9262e0
Address Copilot round 6 on #1481: guard shared_from_this() in SendAsync

bmehta001
and
Copilot
committed
a1da06f
Correct the body-move comment in SendRequestAsync (#1481 review round 7)

bmehta001
and
Copilot
committed
23b6f9a
Harden NoSelfJoin test timeout path (#1481 review round 8)

bmehta001
and
Copilot
committed
62395c7
Move worker-lambda construction inside the try in SendAsync (#1481 review round 9)

bmehta001
and
Copilot
committed
9ae7dd5
Drop issue-number references from code comments

bmehta001
and
Copilot
committed
1ff4b52
Guarantee the callback fires even when Send() throws

bmehta001
and
Copilot
committed
b1e03d8

Commits on Jul 10, 2026

Fix use-after-free dispatching OnDestroy after the completion callback

bmehta001
and
Copilot
committed
cf9bc95
Address review: include <utility>, correct OnDestroy comment, harden test

bmehta001
and
Copilot
committed
f2af5ec
Fix two curl-client lifetime issues found in review

bmehta001
and
Copilot
committed
4af8401
Harden curl-client shutdown: complete-on-send and skip unsafe global cleanup

bmehta001
and
Copilot
committed
89491fd
Harden the completion-guard regression test against the timeout path

bmehta001
and
Copilot
committed
9d69b19
Clarify ~CurlHttpOperation comment for never-sent and synchronous-fallback cases

bmehta001
and
Copilot
committed
bfabf8c
Correct the OnDestroy comment: suppressed once a send is attempted

bmehta001
and
Copilot
committed
e25c43c
Wait for the operation to be destroyed in the self-join test's timeout path

bmehta001
and
Copilot
committed
8e6575b
Wait for the operation to be destroyed on the self-join test's success path

bmehta001
and
Copilot
committed
d2c69dd
Guarantee async ops are destroyed before teardown in both self-join tests

bmehta001
and
Copilot
committed
8650ce1
Hard-stop if a detached curl worker refuses to drain before teardown

bmehta001
and
Copilot
committed
bd49de4

Commits on Jul 13, 2026

Fix curl worker shutdown lifetime

bmehta001
and
Copilot
committed
42d448c

Commits on Jul 30, 2026

Simplify curl worker lifetime handling

bmehta001
and
Copilot
committed
6b793ad
Preserve curl completion semantics on worker failures

bmehta001
and
Copilot
committed
88f5c8f
Merge microsoft/main into the curl self-join fix

bmehta001
and
Copilot
committed
48ad566

Commits on Aug 1, 2026

Default Win32 desktop transport to WinHTTP instead of WinInet

bmehta001
and
Copilot
committed
6a1c050

Commits on Aug 3, 2026

fix winhttp teardown hang on cancellation

bmehta001
and
Copilot
committed
e28ae45
Merge branch 'main' into bhamehta/winhttp-default-windows-transport
bmehta001
authored
b73beec

Commits on Aug 4, 2026

Merge branch 'main' into bhamehta/winhttp-default-windows-transport
bmehta001
authored
2ef5a64
Fix WinHTTP cancellation completion race

bmehta001
and
Copilot
committed
035d2d4

Commits on Aug 5, 2026

Merge branch 'main' into bhamehta/winhttp-default-windows-transport
bmehta001
authored
f227d3f
Join stress-test upload workers before teardown

bmehta001
and
Copilot
committed
287dbc8
Prevent WinHTTP request wrapper use-after-free

bmehta001
and
Copilot
committed
f7fb6f4

Commits on Aug 6, 2026

Align vcpkg iOS deployment target
bmehta001
committed
b2bd27b
Harden Apple packaging integration
bmehta001
committed
ca440fc

Commits on Aug 7, 2026

Migrate Apple builds to canonical CMake variables
bmehta001
committed
c96f7de
Remove unused Windows transport dependencies
bmehta001
committed
50d283a
Merge branch 'main' into bhamehta/winhttp-default-windows-transport
bmehta001
authored
ba35371

Commits on Aug 8, 2026

Merge remote-tracking branch 'origin/main' into bhamehta/winhttp-default-windows-transport
bmehta001
committed
715800d
Merge branch 'main' into bhamehta/fix-curl-async-self-join
bmehta001
authored
85116f0
Fix WinHTTP duplicate completion during teardown
bmehta001
committed
aa80a93
Merge remote-tracking branch 'origin/bhamehta/winhttp-default-windows-transport' into bhamehta/winhttp-default-windows-transport
bmehta001
committed
6deff3f
Merge upstream main after PR 1511
bmehta001
committed
927515f
Keep WinHTTP callback context alive through close
bmehta001
committed
d952202
Make cancellation stress test deterministic
bmehta001
committed
da1fe11
Avoid fixture socket overflow in cancellation stress test
bmehta001
committed
0303c83
Prepare WinHTTP for bounded cancellation
bmehta001
committed
f03af17
Merge PR 1481 Curl lifetime fix
bmehta001
committed
38d1e21
Align bounded cancellation integration
bmehta001
committed
2a1823c
Prepare request draining for PR 1494
bmehta001
committed
4c8d94c
Merge branch 'main' into bhamehta/winhttp-default-windows-transport
bmehta001
authored
9bd4ae2

Commits on Aug 9, 2026

Fix teardown deadlock when flush is skipped during pause

bmehta001
and
Copilot
committed
8b38be1
Merge remote-tracking branch 'origin/bhamehta/winhttp-default-windows-transport' into bhamehta/winhttp-default-windows-transport
bmehta001
committed
9d1b3ec
Fix process-terminating fastfail in oneds_memcpy_s on MSVC

bmehta001
and
Copilot
committed
8d3b67a
Select curl HTTP version at runtime instead of forcing HTTP/2

bmehta001
and
Copilot
committed
0104294
Fix WinHTTP shutdown deadlock when a send fails synchronously

bmehta001
and
Copilot
committed
933ad80
Drain late WinHTTP requests during shutdown
bmehta001
committed
a97db6d

Commits on Aug 10, 2026

Select one Win32 HTTP transport in CMake
bmehta001
committed
226b0b7
Make Annex K overlap checks overflow-safe
bmehta001
committed
2bb62b6
Remove formatter exclusion and validate curl response info
bmehta001
committed
568daa2
Fix WinHTTP certificate validation
bmehta001
committed
b3b1870
Check Curl option configuration failures
bmehta001
committed
d981d63
Harden WinHTTP response handling
bmehta001
committed
78bc0c9
Harden transport response and handle cleanup
bmehta001
committed
a3df0d5
Wait for asynchronous kill-switch drops
bmehta001
committed
abcf98f
Allow slower functional test responses
bmehta001
committed
2cdd5f5
Restore diagnostic functional test timeouts
bmehta001
committed
b4609d3
Preserve WinHTTP setup failures
bmehta001
committed
3e72773
Keep WinHTTP responses when optional headers are unavailable
bmehta001
committed
c0f5967
Apply WinHTTP root checks only to HTTPS
bmehta001
committed
f77202a
Reuse Curl callback byte count
bmehta001
committed
81bd9cd
Match Curl callback signatures
bmehta001
committed
9c980fa
Harden final Windows transport review fixes
bmehta001
committed
d9de71a
Select one legacy Windows transport
bmehta001
committed
6296de7
Wire WinHTTP through consumers
bmehta001
committed
c26517f
Fix SampleCppMini project paths
bmehta001
committed
4191dea
Fix standalone sample paths and warning errors
bmehta001
committed
5056f9d
Clean up SampleCppMini build settings
bmehta001
committed
dee384a

Commits on Aug 11, 2026

Avoid unused-port cancellation test hangs
bmehta001
committed
4d3ef4c
De-duplicate SampleCppMini linker dependencies
bmehta001
committed
8d7b3ff
Use shared unused-parameter macro
bmehta001
committed
d3f64a3
Use explicit fixture base URL
bmehta001
committed
80f19de
Serialize WinHTTP handle operations
bmehta001
committed
5b6e163
Guard legacy Curl socket conversion
bmehta001
committed
9ddb81e
Treat socket poll errors as failures
bmehta001
committed
7afef1c
Preserve Curl option setup order
bmehta001
committed
3298439
Pair Curl callback options with userdata
bmehta001
committed
929caf6

Commits on Aug 12, 2026

Harden Curl async request completion

bmehta001
and
Copilot
committed
44d3eee
Harden Windows HTTP cancellation lifetimes

bmehta001
and
Copilot
committed
b39a383
Default Windows builds to WinHTTP

bmehta001
and
Copilot
committed
fd4ebb5
Reject invalid SQLite event latencies

bmehta001
and
Copilot
committed
c3faeac

Commits on Aug 13, 2026

Serialize deferred task and offline flush teardown
bmehta001
committed
f1b482f
Harden Windows transport callback teardown
bmehta001
committed
875d151
Fail fast across both Windows HTTP transports
bmehta001
committed
47ca55b
Honor HTTP completion contracts on Apple and Curl
bmehta001
committed
104a67d
Preserve offline records after flush failures
bmehta001
committed
ea2e022
Require the canonical SQLite provider option
bmehta001
committed
b9865d3
Focus WinInet CI on production builds
bmehta001
committed
56eb592
Document HTTP response request correlation
bmehta001
committed
e932e93
Wait for deferred task destruction in PAL test
bmehta001
committed
845542d
Drop the legacy SQLite option guard
bmehta001
committed
f4794c2

Commits on Aug 17, 2026

Restore SampleCppMini deployment behavior
bmehta001
committed
667d989
Propagate SQLite persistence failures
bmehta001
committed
851c4b4
Keep SQLite failure tests warning-clean
bmehta001
committed
b804004
Serialize offline flush lifecycle
bmehta001
committed
33d0503
Release worker lock before cancellation waits
bmehta001
committed
76a7eb9
Evaluate WinInet certificate policy after TLS
bmehta001
committed
71acd20
Clarify HTTP request ownership
bmehta001
committed
f3c1f20
Harden Apple HTTP terminal completion
bmehta001
committed
58007b6
Quiesce Curl operations before client teardown
bmehta001
committed
c908b53

Commits on Aug 18, 2026

Order Curl lifecycle events around cancellation
bmehta001
committed
1fe6f75
Scope HTTP ownership to built-in transports
bmehta001
committed
ebbc6de
Compile payload decoder tests under MSBuild
bmehta001
committed
5373f64