Use optional for nullable input object resolver arguments - #364
Draft
Bill Avery (wravery) with Copilot wants to merge 147 commits into
Draft
Bill Avery (wravery) with Copilot wants to merge 147 commits into
Bill Avery (wravery) with Copilot wants to merge 147 commits into
Conversation
Groundwork in CMake, build workflows, and header include cleanup
Add enum value validation
chore: regenerate samples with enum validation
Co-authored-by: wravery <6502881+wravery@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix error compiling in resolve function
Use optional for nullable input object resolver arguments
Sep 15, 2026
…piling-resolve-function # Conflicts: # cmake/version.txt # include/SchemaGenerator.h # include/SchemaLoader.h # include/graphqlservice/GraphQLParse.h # include/graphqlservice/internal/Version.h # res/ClientGen.rc # res/SchemaGen.rc # res/graphqlclient_version.rc # res/graphqljson_version.rc # res/graphqlpeg_version.rc # res/graphqlresponse_version.rc # res/graphqlservice_version.rc # src/SchemaGenerator.cpp # src/SyntaxTree.cpp Co-authored-by: wravery <6502881+wravery@users.noreply.github.com>
Co-authored-by: wravery <6502881+wravery@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nullable input objects could produce mismatched resolver signatures and conversions, particularly for fields returning built-in scalars. Generated code declared
std::optional<T>but passedstd::unique_ptr<T>, causing compilation failures.Argument classification
Type generation
std::optional<T>consistently for nullable input-object resolver arguments.std::unique_ptr<T>for recursive input-object members.