fix(react-dialog): enable keyboard scrolling in long content story - #36736
Draft
Moura (Rodrigorm33) wants to merge 1 commit into
Draft
Moura (Rodrigorm33) wants to merge 1 commit into
Moura (Rodrigorm33) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! This fixes keyboard scrolling in the Dialog "Scrolling Long Content" example (#35603).
Previous Behavior
In the
Scrolling Long ContentDialog story, the overflowing content could be scrolled with the mouse but not with the keyboard. The content had no focusable element, so focus landed onDo Somethingwhen the Dialog opened, andPageDown/arrow keys did not scroll the content.New Behavior
The story passes
tabIndex={0}toDialogContent, so focus lands on the content when the Dialog opens and it can be scrolled withPageDownand the arrow keys.Escapestill closes the Dialog and restores focus to the trigger. The story description now explains when to use this pattern.The change is limited to the example, following bsunderhus's suggestion in #35612. No Dialog runtime or public API code changed, and the story path is excluded from Beachball change-file requirements.
Tested in Edge at 1280×800 and 1280×340: focus cycles through the content,
Do SomethingandClose, andPageDownscrolls the content (or the Dialog surface at the shorter height).Open question: the browser's native focus indicator is kept for now. Fluent focus styles were requested in #35612 for the component-level change; I can apply them to this example if that is expected here.
Related Issue(s)
Thanks for taking a look!