devops: verify javadoc jar contents in CI - #1984
Merged
Merged
Conversation
Javadoc errors don't fail the build, so a misconfiguration can silently produce an empty javadoc jar (see microsoft#1979). Check the jar for a minimum number of class pages and a few key pages on JDK 21.
Pavel Feldman (pavelfeldman)
approved these changes
Sep 14, 2026
Yury Semikhatsky (yury-s)
merged commit Sep 14, 2026
9e7478d
into
microsoft:main
19 of 20 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/verify_javadoc.sh: fails if theplaywrightjavadoc jar has fewer than 300 class pages, misses key pages (Page,Locator, options, assertions, junit), or documentscom.microsoft.playwright.impl.Java_21job; with JDK 8 the javadoc plugin never uses the module path, so the fix(build): restore javadoc jar contents #1979 regression doesn't reproduce there.