devops: move docker publishing to Azure DevOps - #1986
Merged
Yury Semikhatsky (yury-s) merged 4 commits intoSep 15, 2026
Merged
Conversation
The GitHub Actions workflow failed to log in to Azure for v1.63.0. Port upstream's .azure-pipelines/publish-docker.yml (microsoft/playwright#41724).
Dmitry Gozman (dgozman)
approved these changes
Sep 15, 2026
| @@ -0,0 +1,5 @@ | |||
| # The repository root is the Docker build context (see utils/docker/build.sh). | |||
| # Keep registry credentials written by the release pipeline out of the images. | |||
| **/.npmrc | |||
There was a problem hiding this comment.
should this include maven secrets as well?
Member
Author
There was a problem hiding this comment.
No need — MavenAuthenticate injects credentials into ~/.m2/settings.xml on the agent, which is outside the build context (repo root), so COPY . can't pick it up. It reaches the build only via --secret and isn't persisted in any layer. .npmrc needs the entry only because the pipeline writes it into the repo root.
Yury Semikhatsky (yury-s)
merged commit Sep 15, 2026
90bcc6a
into
microsoft:main
24 of 25 checks passed
Yury Semikhatsky (yury-s)
added a commit
that referenced
this pull request
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
azure/loginfor v1.63.0) with.azure-pipelines/publish-docker.yml, ported from upstream (devops: move docker publishing to AzDO playwright#41724)..dockerignorekeeps the pipeline's.npmrcout of images.canaryrelease channel for manual pipeline runs.