Verify signed LLDB-MI macOS artifacts - #14705
Draft
Sean McManus (sean-mcmanus) wants to merge 16 commits into
Draft
Verify signed LLDB-MI macOS artifacts#14705Sean McManus (sean-mcmanus) wants to merge 16 commits into
Sean McManus (sean-mcmanus) wants to merge 16 commits into
Conversation
Copilot started reviewing on behalf of
Sean McManus (sean-mcmanus)
August 25, 2026 01:17
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds post-sign validation for packaged macOS LLDB-MI artifacts.
Changes:
- Names the signing job and adds a dependent verification job.
- Validates archive layout, architecture, signature chain, entitlements, and tamper rejection.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…gent109/verify-lldb-mi-signatures
…gent109/verify-lldb-mi-signatures
…gent109/verify-lldb-mi-signatures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds post-sign verification for the final macOS x86_64 and arm64 LLDB-MI archives. The verification checks the expected payload path and architecture, requires a valid strict non-ad-hoc code signature with an authority chain, confirms the debugger entitlements are unchanged, and proves a modified binary is rejected.
The production pipeline is restricted to successful builds from
refs/heads/main. Feature and pull-request refs cannot run its producer, signing, or post-sign verification stages.The dormant producers are updated for maintained hosted environments: native Python 3.11 on
macOS-15andmacOS-15-arm64, CMake 4 policy compatibility, and targeted compatibility updates for pinned LLVM 13 and current SWIG.Why
The build applies an ad-hoc signature to carry debugger entitlements before MicroBuild replaces it. A successful signing task alone does not prove that the published ZIP contains the intended replacement signature or that the entitlements survived signing and packaging. Verifying the final artifacts catches signing-target, packaging, and post-sign corruption regressions before release.
Production signing is not valid PR validation. The signing and post-sign checks therefore run only after reviewed code reaches
main; branch review relies on static pipeline validation and the repository's ordinary GitHub checks.Compatibility
cstdioheader required by current Xcode headers.FileSPoutput typemap for SWIG 4.1 and later move semantics.PyInt_*APIs with Python 3PyLong_*APIs and require that none remain.Validation
refs/heads/mainwhile post-sign verification still depends on signing.bash -n, ShellCheck, andgit diff --check.Post-sign validation remains intentionally deferred to the first trusted
mainrun containing this change.