Retry test VS Code acquisition and propagate failures - #14752
Draft
Sean McManus (sean-mcmanus) wants to merge 2 commits into
Draft
Retry test VS Code acquisition and propagate failures#14752Sean McManus (sean-mcmanus) wants to merge 2 commits into
Sean McManus (sean-mcmanus) wants to merge 2 commits into
Conversation
Copilot started reviewing on behalf of
Sean McManus (sean-mcmanus)
September 8, 2026 23:10
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The bounded retry behavior and failure propagation are narrowly scoped and comprehensively tested.
Pull request overview
Adds bounded retries for transient VS Code acquisition failures and ensures terminal failures exit nonzero.
Changes:
- Retries transient network failures with exponential backoff.
- Propagates installation failures to the CLI error handler.
- Adds acquisition regression tests to CI.
File summaries
| File | Description |
|---|---|
Extension/package.json |
Registers the acquisition test script. |
Extension/.scripts/vscode.ts |
Implements retries and failure propagation. |
Extension/.scripts/vscode.test.mjs |
Tests retry and CLI failure behavior. |
Extension/.scripts/installAndCopyBinaries.ts |
Removes obsolete undefined-result handling. |
.github/workflows/job-compile-and-test.yml |
Runs acquisition tests before binary acquisition. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retry transient test VS Code acquisition failures with bounded backoff, and make terminal installation failures fail the acquisition command instead of surfacing later as missing native binaries. This is an independent follow-up to the failed Linux acquisition job observed during #14751; the retry passed on unchanged source.
Changes
Validation
yarn test-vscode-acquisition: 21 tests passed, including actual CLI entry-point tests with mocked HTTPS failures and delays.