Adopt package manager command classes

[Eduardo Villalpando Mello (edvilme)]

Summary

Adopts the package manager command classes introduced in #1621 across Pip/UV, Conda, and Poetry.

Changes

• Replaces existing command construction and execution paths with the new command classes.
• Preserves existing command flags, environment targeting, version ordering, prerelease defaults, timeouts, and Poetry cwd behavior.
• Removes superseded utility wrappers and obsolete tests tied to those utilities.
• Adds a parametrized package-manager roundtrip integration test (install → list → direct-deps → available-versions → uninstall) driven by the public API and grouped by managerId, so future managers are covered automatically. The available-versions step is capability-guarded so it runs when the API surfaces getPackageAvailableVersions and skips gracefully otherwise.

Relationship

• Targets main directly and depends only on the already-merged command classes (Introduce package manager command classes #1621). Independent of the smoke-tests PR Add package manager command smoke tests #1677.
• Replaces Adopt package manager command classes #1678, whose base branch could not be changed after GitHub registered it as part of a stack; the stack has been undone and this PR targets main.
• The command unit tests live in Add package manager command smoke tests #1677 (reworked to assert parsed values). They were removed from this branch to avoid duplicate/overlapping copies.

Testing

• npm run compile-tests
• npm run unittest (1,475 passing)
• Roundtrip integration test runs in the extension host via npm run integration-test.

[Copilot]

Pull request overview

This PR migrates Pip/UV, Conda, and Poetry package manager call sites to the newer package-manager command class layer (introduced in #1621), and removes older helper utilities/tests that those call sites depended on.

Changes:

• Replaces ad-hoc command construction/execution with concrete command classes for Pip/UV, Conda, and Poetry.
• Refactors Pip/Conda/Poetry package manager flows to use command objects (including progress + cancellation wiring).
• Removes superseded parsing/execution utilities and replaces related unit tests with command-focused tests.

Reviewed changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
src/test/managers/poetry/commands.unit.test.ts	Adds Poetry command smoke tests (currently mostly “does not reject”).
src/test/managers/conda/commands.unit.test.ts	Adds Conda command smoke tests (currently mostly “does not reject”).
src/test/managers/builtin/commands.unit.test.ts	Adds Pip/UV command smoke tests (currently mostly “does not reject”).
src/test/managers/builtin/pipVersions.unit.test.ts	Removes tests for the old pip-index-versions parsing helper.
src/test/managers/builtin/pipListUtils.unit.test.ts	Removes tests for the old pip list / uv tree parsing helpers.
src/managers/poetry/poetryPackageManager.ts	Switches Poetry package operations to command classes; refactors Poetry cwd selection into helper.
src/managers/conda/condaUtils.ts	Removes superseded managePackages() helper.
src/managers/conda/condaPackageManager.ts	Switches Conda package operations/list/version/available-versions to command classes.
src/managers/builtin/utils.ts	Adds parsePackageSpecs() helper and removes older pip-related utility functions from this module.
src/managers/builtin/pipUtils.ts	Switches installed-package enumeration to command classes; removes isPipInstallCommand().
src/managers/builtin/pipPackageManager.ts	Switches pip/uv operations to command classes; refactors available versions and direct-name listing.
src/managers/builtin/pipListUtils.ts	Deletes the old pip list / uv tree parsing module.
src/managers/builtin/helpers.ts	Adjusts logging behavior for python stderr output.
package-lock.json	Lockfile update (tslib metadata change).

[Copilot]

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.

Suppressed comments (3)

src/managers/builtin/pipPackageManager.ts:185

• getPackages() now directly awaits listCmd.execute() and then caches the result. If runPython/runUV fails (e.g. pip missing/broken), execute() will reject and the public API call will throw rather than returning undefined as before, potentially breaking callers/UI. Consider catching execution errors here and returning undefined (and avoid caching an empty list on failure).

            const data = await listCmd.execute();
            const packages = (data ?? []).map((pkg) => this.api.createPackageItem(pkg, environment, this));
            this.packages.set(environment.envId.id, packages);
            return packages;

src/managers/builtin/pipUtils.ts:289

• getWorkspacePackagesToInstall() now calls listCmd.execute() without any error handling. If pip/uv listing fails, this helper will throw and can abort the package selection flow. Previously the pip list path handled failures and returned undefined/empty results. Consider catching here and treating the installed list as unknown so the picker can still proceed.

                UvListCommand,
            );
            const data = await listCmd.execute();
            installed = data?.map((pkg) => pkg.name);
        }

src/managers/poetry/poetryPackageManager.ts:234

• fetchPackagesFromTool() will currently throw (e.g. if Poetry is missing or poetry show fails), and PythonEnvironmentApi.getPackages() forwards manager errors without catching. To keep getPackages() resilient for callers/UI, consider making this helper return an empty list on tool failure (and log), rather than throwing.

        const cwd = await this.getPoetryCwd(environment);
        const showCmd = new PoetryShowCommand({
            pythonExecutable: poetry,
            cwd,
            log: this.log,

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Stella Huang (StellaHuang95)]

🔒 Automated review in progress — Stella Huang (@StellaHuang95) is auto-reviewing this PR.

[Stella Huang (StellaHuang95)]

GitHub cannot anchor PR review comments to unchanged lines in the diff. Falling back to a general PR comment for src/test/managers/builtin/pipListUtils.unit.test.ts:L1.

Warning · Non-blocking recommendation

Deleting these parser tests removes deterministic malformed-output coverage for pip list, uv tree, and available-version parsing. The new live integration test does not exercise those branches; retain equivalent command-layer unit coverage in this change or ensure it is already present before removing these tests. [verified]

[Eduardo Villalpando Mello (edvilme)]

Stella Huang (@StellaHuang95) Addressed the parser-coverage recommendation in 39f8559. Added deterministic command-layer tests for pip/uv list parsing, malformed and non-array output, incomplete entries, uv tree top-level filtering, direct-name normalization, and available-version parsing/filtering. This retains coverage without restoring the superseded legacy parser helpers.