Skip to content

Add deferred worksheet font color edits - #18

Merged
shps951023 merged 1 commit into
release/nuget-0.1.0-preview.2from
feature/issue-16-deferred-style-edit-clean
Sep 14, 2026
Merged

shps951023 merged 1 commit into
release/nuget-0.1.0-preview.2from
feature/issue-16-deferred-style-edit-clean

Conversation

@shps951023

Copy link
Copy Markdown
Member

Adds a Rust-native fluent editor for deferred font-color updates to existing worksheet cells.

  • collect typed CellReference/RgbColor operations and normalize them at save()
  • apply last-write-wins semantics in worksheet coordinate order
  • preserve unrelated font and XF properties while deduplicating generated styles
  • stream worksheet XML through temporary storage and atomically validate/commit the package
  • cover reverse ordering, duplicate updates, repeated saves, no-op saves, case-insensitive sheet lookup, style reuse, and rollback on failure
  • document the Rust-only compatibility boundary in English and Simplified Chinese

Validation:

  • cargo +1.85.0 test --workspace --all-targets --locked
  • cargo +1.85.0 test -p miniexcel --test insert --locked
  • cargo +1.85.0 clippy --workspace --all-targets --locked -- -D warnings
  • cargo +1.85.0 doc --workspace --no-deps --locked
  • focused rustfmt checks for changed Rust files

This clean PR supersedes #17, whose branch inherited unrelated local history.

Closes #16

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 9f9a7867-421f-496f-b165-7d7f3be57d62

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@shps951023
shps951023 merged commit f95c22b into release/nuget-0.1.0-preview.2 Sep 14, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant