Improve Go XLSX fidelity and publish benchmarks - #174
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (290)
📒 Files selected for processing (9)
📝 WalkthroughWalkthroughThe Go XLSX converter now preserves sparse worksheet layout, formats boolean cells, skips empty worksheets, paginates long single-column text, and retains fallback pages. Tests, benchmark coverage, ignore rules, and feature-parity records were updated. ChangesGo XLSX conversion
Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Bug fix ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
shps951023
changed the title
shps951023
changed the title
shps951023
changed the title
shps951023
changed the title
shps951023
marked this pull request as ready for review
September 14, 2026 12:31
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved critical allocation-safety findings, a moderate rendering issue, and report nits remain.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Improves Go XLSX rendering fidelity and publishes complete benchmark results.
Changes:
- Adds overflow pagination, sparse-position preservation, empty-sheet handling, and boolean formatting.
- Adds focused regression tests and rendering updates.
- Publishes benchmark reports and updates parity metadata.
File summaries
| File | Summary |
|---|---|
minipdf-go/xlsx.go |
XLSX extraction and pagination changes. Two critical findings (3 votes each) concern unbounded row and column allocations before configured limits are applied. |
minipdf-go/office.go |
Text overflow rendering updates. One moderate finding (3 votes) concerns explicit newlines being converted to spaces. |
minipdf-go/office_test.go |
Regression coverage for XLSX behavior. |
FEATURE_PARITY.md |
Updated parity status and benchmark history. |
artifacts/go-benchmark/issue/xlsx/report/comparison_report.md |
Published benchmark report. Two nit findings (2 votes and 1 vote) concern emoji markers and incorrect list numbering. |
artifacts/go-benchmark/issue/xlsx/report/comparison_manifest.json |
Benchmark case manifest. |
artifacts/go-benchmark/issue/xlsx/report/benchmark_coverage.json |
Benchmark coverage results. |
.gitignore |
Allows generated benchmark artifacts to be tracked. |
Review details
- Files reviewed: 6/299 changed files
- Comments generated: 4
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+215
to
+216
| for len(row)+1 < columnNumber { | ||
| row = append(row, "") |
Comment on lines
+233
to
+234
| for len(lines)+1 < rowNumber { | ||
| lines = append(lines, "") |
Comment on lines
+155
to
+159
| if noWrap { | ||
| wrapped = append(wrapped, line) | ||
| } else { | ||
| wrapped = append(wrapped, wrapText(line, textCharactersPerLine(pageSize, margins))...) | ||
| } |
|
|
||
| ## Summary | ||
|
|
||
| | # | Test Case | Valid | Text Sim | Visual Avg | Pages (M/R) | Overall | | ||
| |---|-----------|-------|----------|------------|-------------|--------| | ||
| | 1 | 🔴 Issue202609031340 | ❌ | 0.175 | 0.5866 | 3/4 | **0.4046** | | ||
| | 1 | 🔴 Academic Achievement Summary Table | ✅ | 0.3235 | 0.4218 | 9/2 | **0.3981** | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TRUEandFALSEValidation
go test ./...go vet ./...go test -race ./...0.8436initial baseline to0.8522classic09_long_text:0.1840at1/12pages to0.8942at12/12pagesclassic11_sparse_rows:0.6990to0.9996classic12_sparse_columns:0.6993to0.9995classic30_mixed_empty_and_filled_sheets:0.6834to0.9993classic42_boolean_values:0.9264to0.98690.4929Remaining Go parity work
XLSX number/date formats, styles, merged-cell layout, images and charts; DOCX tables and images; PPTX shapes and images; and advanced font fallback/shaping remain tracked in
FEATURE_PARITY.md.Summary by CodeRabbit
New Features
TRUEorFALSE.Bug Fixes
Documentation