Improve Java DOCX pagination and rendering fidelity - #179
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughChangesDOCX rendering
Estimated code review effort: 4 (Complex) | ~45 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant DocxConverter
participant PoiDocxRenderer
participant PageContext
participant PDFBox
DocxConverter->>PoiDocxRenderer: render DOCX with tables
PoiDocxRenderer->>PageContext: derive page layout and footer data
PageContext->>PDFBox: render paragraphs, tables, and page numbers
PDFBox-->>DocxConverter: return multi-page PDF
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This follows PR #178 with the additional commits that were pushed to the same branch after that PR merged.
Validation
mvn -f D:/git/MiniPdf-java-docx/minipdf-java/pom.xml -pl minipdf -am '-Dtest=ClassicFixtureSmokeTest,PoiDocxRendererTest' '-Dsurefire.failIfNoSpecifiedTests=false' testgit diff --check origin/main...origin/fix/java-docx-pagination-orientationorigin/maincompleted without conflictsCompatibility
No public API changes. Changes are scoped to Java DOCX rendering and regression tests.
Summary by CodeRabbit
New Features
Bug Fixes