Skip to content

fix: set default false for statObject's deletemarker - #243

Open
jiuker wants to merge 2 commits into
minio:mainfrom
jiuker:fix-set-default-false-for-statObject's-deletemarker
Open

fix: set default false for statObject's deletemarker#243
jiuker wants to merge 2 commits into
minio:mainfrom
jiuker:fix-set-default-false-for-statObject's-deletemarker

Conversation

@jiuker

@jiuker jiuker commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

fix: set default false for statObject's deletemarker
fix #195

can be read to true for Undefined Behavior

fix: set default false for statObject's deletemarker
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@jiuker, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 45 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 3b95a58c-5144-4eb2-a2ce-3a4947907b7c

📥 Commits

Reviewing files that changed from the base of the PR and between 2684417 and 7cf5afe.

📒 Files selected for processing (1)
  • tests/tests.cc
📝 Walkthrough

Walkthrough

The response types now initialize delete_marker to false. The StatObject() test verifies that retrieved objects are not marked for deletion.

Changes

Delete marker defaults

Layer / File(s) Summary
Response defaults and StatObject() validation
include/miniocpp/response.h, tests/tests.cc
StatObjectResponse::delete_marker and DeletedObject::delete_marker now default to false. The StatObject() test fails when delete_marker is true.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: harshavardhana

Poem

I’m a rabbit with a marker set right,
False by default, clean and bright.
The object test checks the state,
No phantom delete shall pass the gate.
Hop, hop—safe responses take flight!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The changes set StatObjectResponse.delete_marker to false and verify that existing objects are not delete markers [#195].
Out of Scope Changes check ✅ Passed The changes are limited to related delete-marker defaults and validation for StatObject behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: setting the delete_marker default to false for StatObjectResponse.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StatObjectResponse contains delete_marker for existing object

1 participant