Tighten the guardrail against serializer queries - #292
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Clarifies that serializers must avoid both direct and indirectly triggered database queries.
Changes:
- Expands the serializer query guardrail.
- Adds indirect function/property access guidance.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
skills/python/drf-api-performance/SKILL.md |
Strengthens the primary rule. |
skills/python/drf-api-performance/references/serializers.md |
Documents indirect query risks. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
shaidar
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
N/A
Description (What does it do?)
This clarifies the rule about putting queries in serializers to have it be inclusive of queries made because a serializer is making a function call that does a query.
How can this be tested?
It's hard to test this because LLMs aren't deterministic, we'll just have to see if it does it less over time.