Skip to content

[PWGLF,PWGMM] Please consider the following formatting changes to #17361 #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjkim525 merged 1 commit into from
Aug 6, 2026
Merged

[PWGLF,PWGMM] Please consider the following formatting changes to #17361 #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions PWGMM/Lumi/Tasks/lumiVertex.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.

Check failure on line 1 in PWGMM/Lumi/Tasks/lumiVertex.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/workflow-file] 

Name of a workflow file must match the name of the main struct in it (without the PWG prefix). (Class implementation files should be in "Core" directories.)

Check failure on line 1 in PWGMM/Lumi/Tasks/lumiVertex.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/o2-task] 

Specify task name only when it cannot be derived from the struct name. Only append to the default name.
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
// All rights not expressly granted are reserved.
//
Expand Down Expand Up @@ -60,7 +60,7 @@

DECLARE_SOA_COLUMN(VertexChi2, vertexChi2, double);
DECLARE_SOA_COLUMN(NContrib, nContrib, int);
DECLARE_SOA_COLUMN(BCID, bcid, int32_t);

Check failure on line 63 in PWGMM/Lumi/Tasks/lumiVertex.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/o2-column] 

Use UpperCamelCase for names of O2 columns and matching lowerCamelCase names for their getters.
DECLARE_SOA_COLUMN(RunNumber, runNumber, int32_t);
DECLARE_SOA_COLUMN(GlobalBC, globalBC, uint64_t);
DECLARE_SOA_COLUMN(LocalBC, localBC, int32_t);
Expand All @@ -71,15 +71,15 @@
DECLARE_SOA_COLUMN(IsCollisionTVX, isCollisionTVX, bool);
DECLARE_SOA_COLUMN(HasAnyFT0Trigger, hasAnyFT0Trigger, bool);
DECLARE_SOA_COLUMN(HasFT0AC, hasFT0AC, bool);
DECLARE_SOA_COLUMN(FT0TriggerMask, ft0TriggerMask, uint8_t);

Check failure on line 74 in PWGMM/Lumi/Tasks/lumiVertex.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/o2-column] 

Use UpperCamelCase for names of O2 columns and matching lowerCamelCase names for their getters.
DECLARE_SOA_COLUMN(FT0Rate, ft0Rate, float);

Check failure on line 75 in PWGMM/Lumi/Tasks/lumiVertex.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/o2-column] 

Use UpperCamelCase for names of O2 columns and matching lowerCamelCase names for their getters.
DECLARE_SOA_COLUMN(NCollisions, nCollisions, int32_t);
DECLARE_SOA_COLUMN(NSelectedCollisions, nSelectedCollisions, int32_t);
DECLARE_SOA_COLUMN(IsCollidingBC, isCollidingBC, bool);
DECLARE_SOA_COLUMN(IsFT0SuperLeading, isFT0SuperLeading, bool);
DECLARE_SOA_COLUMN(HasPreviousFT0Activity, hasPreviousFT0Activity, bool); //! Whether a preceding FT0 CTP activity was observed
DECLARE_SOA_COLUMN(BCsSinceLastFT0Activity, bcsSinceLastFT0Activity, int64_t); //! -1 when the preceding activity is unknown

Check failure on line 81 in PWGMM/Lumi/Tasks/lumiVertex.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/o2-column] 

Use UpperCamelCase for names of O2 columns and matching lowerCamelCase names for their getters.
DECLARE_SOA_COLUMN(PVRefitValid, pvRefitValid, bool);

Check failure on line 82 in PWGMM/Lumi/Tasks/lumiVertex.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/o2-column] 

Use UpperCamelCase for names of O2 columns and matching lowerCamelCase names for their getters.
} // namespace full
DECLARE_SOA_TABLE(EventInfo, "AOD", "EventInfo", full::TimeStamp, full::VertexX,
full::VertexY, full::VertexZ,
Expand Down Expand Up @@ -134,7 +134,7 @@
PresliceUnsorted<CollisionsWithEvSels> collisionsPerFoundBC =
aod::evsel::foundBCId;
Preslice<UnfilteredTracks> tracksPerCollision =
aod::track::collisionId;
aod::track::collisionId;

struct : ConfigurableGroup {
Configurable<uint64_t> ftts{"ftts", 0,
Expand Down Expand Up @@ -727,9 +727,9 @@
int32_t nSelectedCollisions = 0;
for (const auto& collision : collisionsInBC) {
auto tracksInCollision =
unfilteredTracks.sliceBy(
tracksPerCollision,
collision.globalIndex());
unfilteredTracks.sliceBy(
tracksPerCollision,
collision.globalIndex());

if (processCollision(collision, bc, tracksInCollision,
relativeTimestamp, globalBC, localBC,
Expand All @@ -752,6 +752,6 @@

WorkflowSpec defineDataProcessing(ConfigContext const& cfgc)
{
WorkflowSpec w{adaptAnalysisTask<lumiTask>(cfgc, TaskName{"lumiVertex"})};

Check failure on line 755 in PWGMM/Lumi/Tasks/lumiVertex.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/o2-task] 

Specified task name lumiVertex produces device name lumi-vertex which does not match the device name lumi-task from the struct name lumiTask. (Matching struct name LumiVertex)
return w;
}
Loading