fix(metal): revert inactive NAX MoE simdgroup skipping - #4404
Draft
jonathan308 wants to merge 1 commit into
Draft
Conversation
…muls on NAX (ml-explore#4352)" This reverts commit c7ff35d.
Collaborator
|
Thanks for flagging this. I will look into it soon. |
Member
|
/cc @RohanGautam |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Revert #4352's inactive-simdgroup NAX MoE optimization after a physical mixed-Mac tensor-parallel A/B isolated it as the trigger for repeatable lost JACCL completions.
Evidence
all_reduceprogress and the request returns zero tokens.The detailed physical reproducer and measurements are linked in the issue.
Why a revert
The issue is hardware/workload-specific and current CI cannot exercise a heterogeneous M3 Ultra + M5 Max JACCL pair. Restoring the pre-#4352 code is the smallest proven-safe change. A follow-up can reintroduce the optimization with a safe uniform execution scheme or an explicit capability gate.
This PR is a draft pending maintainer guidance and any additional isolated-kernel reproducer they want.
Refs #4403.