ENH: make compute_covariance work with Evoked objects - #14129
Merged
Conversation
BabaSanfour
requested review from
agramfort,
drammock and
larsoner
as code owners
August 3, 2026 23:15
Member
Author
|
@larsoner PR is ready; code works as intended, one improvement would be changing epochs to inst, this would require some deprecation cycles (?). |
wmvanvliet
reviewed
Aug 4, 2026
wmvanvliet
reviewed
Aug 4, 2026
wmvanvliet
reviewed
Aug 4, 2026
Contributor
|
This is useful, also for the upcoming dipole fitting GUI :) |
Member
Author
|
Thanks @wmvanvliet , i was going to make it an inst .. but not sure how i should handle deprecation here. Should i just change it ? |
Contributor
|
it's only not compatible if someone explicitly does |
drammock
reviewed
Aug 4, 2026
wmvanvliet
reviewed
Aug 4, 2026
Contributor
|
Thanks, @BabaSanfour! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue (if any)
Closes #14115.
What does this implement/fix?
Accept Evoked through existing epochs argument and reject keep_sample_mean=False. With Evoked data we treat samples will be treated as observations and channels as variables: spatial covariance over time, not an estimate of trial-to-trial noise covariance
Possible alternatives/Improvements
Additional information
With the help of claude Opus5; all lines added were read and double checked.