Conversation
CarinaFo
marked this pull request as ready for review
September 20, 2026 03:06
CarinaFo
requested review from
agramfort,
drammock and
larsoner
as code owners
September 20, 2026 03:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing #14287, I noticed that
interpolate_bridged_electrodesclearsinst.info["bads"]before checking bad_limit. If too many electrodes are bridged together, theRuntimeErroris raised before the original bads are restored. The user's bad-channel list is silently lost.This PR:
info["bads"]to after thebad_limitcheck. Nothing before that point usesinfo["bads"], so behaviour is otherwise unchanged.bad_limitpart oftest_interpolate_bridged_electrodesto mark a channel as bad and assert it is still marked bad after the error is raised. The new assertion fails onmainand passes with this change.AI disclosure:
Claude Opus 5 was used to help with formatting this PR and the changelog entry.