Avoid reading Configuration in Directory.Build.props - #1776
Conversation
|
The first Windows Debug run had two timing-sensitive ASP.NET Core protocol tests fail on one target framework; the same test assembly passed on the other Windows target frameworks, Windows Release passed, and all Linux/macOS jobs passed. The build output paths were correct. I pushed an empty CI-only commit to rerun the matrix because contributors cannot rerun upstream jobs directly. |
|
The rerun confirms this is unrelated to the Directory.Build.props change: the Windows Debug build succeeded with zero warnings/errors, and every test assembly reported zero failures (including 2,341/2,341 on net8/net9/net10 and 2,041 passed with expected skips on net472). The job exits 1 only after the blame collector reports that |
Summary
Directory.Build.propsDirectory.Build.targets, afterConfigurationis initializedsrc/Directory.Build.targetsand require SDK 10.0.101 or newerCloses #995
Test plan
dotnet build ModelContextProtocol.slnx --configuration Debug --no-incrementaldotnet build ModelContextProtocol.slnx --configuration Release --no-incrementaldotnet test ModelContextProtocol.slnx --configuration Debug --no-build --no-restore --filter "(Execution!=Manual)"(8,862 passed)dotnet pack ModelContextProtocol.slnx --configuration Release --no-build --no-restoreartifacts/TestResults/Debug