ci(v1): pin workflow branch filters to v1/main, re-enabling the e2e gate - #2066
Merged
Conversation
The push filter still listed `main`, and `pull_request` carried no branch filter at all — both leftovers from when the v1 line was itself `main`. Neither describes the topology now: `v1/main` publishes straight to the `v1-latest` dist-tag and never merges into `main`, which carries v2 and publishes `latest`. No behavior change on any path that runs today. For `push`, GitHub runs the workflow file from the pushed commit, so this file was only ever consulted for `v1/main`; `main` could not match unless a commit on that branch carried a v1-shaped tree. The same resolution rule made the unfiltered `pull_request` harmless, since a PR's workflow comes from its merge ref. The `release` trigger is untouched, so publishing is unaffected — it is gated on the event type and the release's target commit, never on these filters. The value is that the file now states its intent, and the stale `main` entry can no longer become live if anything is ever restored onto that branch. Closes #2065 Signed-off-by: cliffhall <cliff@futurescale.com>
2 tasks
`e2e_tests.yml` filtered on `branches: [main]` for both `push` and `pull_request` — the same leftover as main.yml, but with a sharper consequence: `main` never matches on this branch, so the filter matched nothing and the suite has never run on `v1/main` at all. The branch's full run history contains zero `Playwright Tests` runs, only `Run install, format, lint, build, and test on every push` and `CLI Tests`. Repointed both filters at `v1/main` so the gate actually gates. Unlike the main.yml change this is a real behavior change — it turns a dead workflow back on — so it is deliberately a separate commit. Refs #2065 Signed-off-by: cliffhall <cliff@futurescale.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2065
Two workflows on this branch still filtered on
main, left over from when the v1line was
main. They look like the same defect but differ sharply inconsequence, so they're two commits.
1.
main.yml— stale, but inert (c7dc8f70)mainentry from thepushfilterpull_requesttrigger tov1/mainmainNo behavior change on any path that runs today. For
push, GitHub runs theworkflow file from the pushed commit, so this file was only ever consulted
when the pushed ref was
v1/main; themainentry could not match unless acommit on
maincarried a v1-shaped tree, and it doesn't —origin/mainholdsclaude.ymlplus amain.ymlthat is the v2 workflow. The same rule made theunfiltered
pull_requestharmless, since a PR's workflow comes from its mergeref. The value is that the file now states its intent and the stale entry can't
become live later.
The dist-tag hazard people reach for first is already handled independently and
is not what this touches:
publish-allpins--tag v1-latest, with thereasoning commented in place, and a mis-targeted release is caught by the version
assert on both lines.
2.
e2e_tests.yml— the same leftover, but it had disabled a gate (95fa9a1c)branches: [main]on bothpushandpull_requestmatches nothing on thisbranch, so the Playwright suite had never run on
v1/mainat all — confirmedagainst the branch's full run history, which held only
Run install, format, lint, build, and test on every pushandCLI Tests, andzero
Playwright Testsruns.Both filters now point at
v1/main. Unlike the first commit this is abehavior change — it turns a dead workflow back on — which is why it's separate.
releaseis untouched in both, so publishing is unaffected.cli_tests.ymlneeds no change: it filters on
paths: cli/**with no branch filter.Verified
The PR's own run is the proof, since the fixed
pull_requestfilter is whatmakes these execute here at all:
test(Playwright) — pass, 2m28s:Running 24 tests using 1 worker→24 passed (42.8s), Chromium + Firefox. The suite is healthy; the gate hadsimply been switched off.
build— pass, 1m18spublish/publish-github-container-registry— correctlyskippingon anon-release event, confirming the release gating is untouched
prettier --checkclean on both files (the repo'sprettier-checkisprettier --check ., so it covers workflow YAML), and both parse with theirtriggers intact