fix: stop pagination on empty cursors - #954
Merged
Kehrlann merged 1 commit intoAug 7, 2026
Merged
Conversation
Kehrlann
approved these changes
Aug 7, 2026
Signed-off-by: Nanook <nanookclaw@users.noreply.github.com>
Kehrlann
force-pushed
the
fix/empty-pagination-cursors
branch
from
August 7, 2026 14:13
e18d0fa to
8873da1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #575.
listTools()already treats an emptynextCursoras the end of pagination. This applies the same guard to the other async aggregate list methods so servers that return""instead ofnulldo not trigger a repeated request with an empty cursor.The change covers
listResources(),listResourceTemplates(), andlistPrompts(), and adds regression tests that verify each method stops after the first response whennextCursoris empty.Testing
./mvnw -pl mcp-core,mcp-test spring-javaformat:validategit diff --checkI also tried
./mvnw -pl mcp-test -am -Dtest=McpAsyncClientTests test, but this environment has only a JRE installed (javacis missing), so Maven fails before running tests withrelease version 17 not supported. A baseline compile on unmodified HEAD fails the same way locally.