[Schema][Server] feat: support sampling with tools - #409
Open
wWzZb wants to merge 1 commit into
Open
Conversation
wWzZb
marked this pull request as ready for review
August 7, 2026 07:13
wWzZb
requested review from
CodeWithKyrian,
Nyholm,
chr-hertel and
soyuka
as code owners
August 7, 2026 07:13
chr-hertel
added
Server
chr-hertel
changed the title
chr-hertel
requested changes
Aug 10, 2026
chr-hertel
left a comment
chr-hertel
left a comment
Member
There was a problem hiding this comment.
Thanks @wWzZb for working on this - please extend the CHANGELOG.md for upcomgin release 0.8.0, extend docs and example where meaningful and double-check if there's still missing unit tests here and there - i at least caught one place where i think it makes sense to add some.
Thanks again, great addition for feature parity with the spec! 👍
| public readonly TextContent|ImageContent|AudioContent|ToolUseContent|array $content, | ||
| public readonly string $model, | ||
| public readonly ?string $stopReason = null, | ||
| public readonly SamplingStopReason|string|null $stopReason = null, |
Member
There was a problem hiding this comment.
if we adopt the enum here, we can basically drop string, right?
Suggested change
| public readonly SamplingStopReason|string|null $stopReason = null, | |
| public readonly ?SamplingStopReason $stopReason = null, |
| public function __construct( | ||
| public readonly Role $role, | ||
| public readonly TextContent|ImageContent|AudioContent $content, | ||
| public readonly TextContent|ImageContent|AudioContent|ToolUseContent|ToolResultContent|array $content, |
Member
There was a problem hiding this comment.
please try to introduce a
@phpstan-type SamplingContent = TextContent|ImageContent|AudioContent|ToolUseContent|ToolResultContentso we could maybe shorten this with:
Suggested change
| public readonly TextContent|ImageContent|AudioContent|ToolUseContent|ToolResultContent|array $content, | |
| public readonly SamplingContent|SamplingContent[], |
Comment on lines
61
to
73
| $sampling = null; | ||
| $samplingContext = null; | ||
| $samplingTools = null; | ||
| if (isset($data['sampling'])) { | ||
| $sampling = true; | ||
| if (\is_array($data['sampling'])) { | ||
| $samplingContext = isset($data['sampling']['context']); | ||
| $samplingTools = isset($data['sampling']['tools']); | ||
| } elseif (\is_object($data['sampling'])) { | ||
| $samplingContext = property_exists($data['sampling'], 'context'); | ||
| $samplingTools = property_exists($data['sampling'], 'tools'); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
please add tests for those code branches
chr-hertel
added
the
needs more work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
toolsandtoolChoiceto sampling requests and wire them throughClientGateway::sample().sampling.contextandsampling.toolsclient capabilities.Why
The SDK did not yet model the SEP-1577 protocol additions, so servers could not express tool-enabled sampling loops through the typed API.
Impact
Existing single-content sampling calls remain supported. The new constructor parameters are optional and appended to preserve current call sites.
Checks
make csmake phpstanmake tests— 936 tests, 2781 assertions, 7 existing skipsCloses #155