[Client] Implement setMaxRetries connection retries - #413
Open
chr-hertel wants to merge 6 commits into
Open
Conversation
chr-hertel
requested review from
CodeWithKyrian,
Nyholm and
soyuka
as code owners
August 10, 2026 23:05
chr-hertel
added
bug
Contributor
There was a problem hiding this comment.
Pull request overview
Implements configurable client connection retries and fixes stale pending requests after timeouts.
Changes:
- Adds connection retry, cleanup, and linear backoff behavior.
- Validates retry configuration and documents its semantics.
- Adds unit coverage for retries, exhaustion, and timeout recovery.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/Client.php |
Implements connection retries and backoff. |
src/Client/Builder.php |
Clarifies retry configuration semantics. |
src/Client/Configuration.php |
Rejects negative retry counts. |
src/Client/Protocol.php |
Cleans up pending requests reliably. |
tests/Unit/ClientTest.php |
Tests connection retry behavior. |
docs/client.md |
Documents connection retries. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client\Builder::setMaxRetries()has never had an implementation — it was added in the initial client commit, stored onConfiguration, and read by nothing, so the documented "retry attempts for failed connections" never happened.Client::connect()now retries a failed attempt, closing the transport in between so a retry gets a fresh process / drops the failed HTTP session, with a short linear backoff. The value counts retries rather than attempts, and0disables retrying.This also fixes a prerequisite bug in
Client\Protocol::request(): only the response path cleared a pending request, so one that timed out stayed pending forever and made every following request fail as timed out immediately — which would have made retries useless on the timeout path.