Skip to content

refactor: simplify get_display_name control flow - #3533

Closed
codearc-co wants to merge 1 commit into
modelcontextprotocol:mainfrom
codearc-co:fix/simplify-get-display-name
Closed

codearc-co wants to merge 1 commit into
modelcontextprotocol:mainfrom
codearc-co:fix/simplify-get-display-name

Conversation

@codearc-co

Copy link
Copy Markdown

Remove duplicate title check by moving universal title-first logic outside the isinstance(Tool) conditional. This improves readability and maintainability while preserving all existing behavior.

Fixes #3480

  • All 12 existing test assertions pass
  • 100% code coverage maintained
  • Type checking clean (pyright)
  • Linting clean (ruff)

Fixes #

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I am assigned to the linked issue (or it is labeled help wanted, or I'm a maintainer)
  • I have disclosed any AI assistance and can explain the change in my own words
  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Remove duplicate title check by moving universal title-first
logic outside the isinstance(Tool) conditional. This improves
readability and maintainability while preserving all existing
behavior.

Fixes modelcontextprotocol#3480

- All 12 existing test assertions pass
- 100% code coverage maintained
- Type checking clean (pyright)
- Linting clean (ruff)
@github-actions github-actions Bot added the missing-issue-link Auto-closed: PR needs a linked issue assigned to its author (see CONTRIBUTING.md) label Sep 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #3480.

If a maintainer assigns you to #3480, this PR reopens on its own and there's nothing more you need to do here. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. What does help is engaging on the issue itself by confirming the repro, explaining why it matters for your use case, or describing the approach you'd take.

You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way.

CONTRIBUTING.md has the full reasoning, but in short:

  • We're a small team with very little capacity to review community PRs right now.
  • Many recent PRs are AI-generated with little human review, and reviewing one carefully still costs a maintainer as much time as it ever did. A well-described issue is usually more useful to us than the code.

Maintainers: reopen, remove missing-issue-link, or add bypass-issue-check to override.

@github-actions github-actions Bot closed this Sep 18, 2026
@codearc-co

codearc-co commented Sep 18, 2026

Copy link
Copy Markdown
Author

✅ Full Verification Report

Test Results

All 5 tests pass:

tests/server/mcpserver/test_title.py::test_server_name_title_description_version PASSED tests/server/mcpserver/test_title.py::test_tool_title_precedence PASSED tests/server/mcpserver/test_title.py::test_prompt_title PASSED tests/server/mcpserver/test_title.py::test_resource_title PASSED tests/server/mcpserver/test_title.py::test_get_display_name_utility PASSED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-issue-link Auto-closed: PR needs a linked issue assigned to its author (see CONTRIBUTING.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simplify src/mcp/shared/metadata_utils.py::get_display_name logic.

2 participants