refactor: simplify get_display_name control flow - #3533
codearc-co wants to merge 1 commit into
Conversation
Remove duplicate title check by moving universal title-first logic outside the isinstance(Tool) conditional. This improves readability and maintainability while preserving all existing behavior. Fixes modelcontextprotocol#3480 - All 12 existing test assertions pass - 100% code coverage maintained - Type checking clean (pyright) - Linting clean (ruff)
|
This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #3480. If a maintainer assigns you to #3480, this PR reopens on its own and there's nothing more you need to do here. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. What does help is engaging on the issue itself by confirming the repro, explaining why it matters for your use case, or describing the approach you'd take. You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way. CONTRIBUTING.md has the full reasoning, but in short:
Maintainers: reopen, remove |
✅ Full Verification ReportTest ResultsAll 5 tests pass: tests/server/mcpserver/test_title.py::test_server_name_title_description_version PASSED tests/server/mcpserver/test_title.py::test_tool_title_precedence PASSED tests/server/mcpserver/test_title.py::test_prompt_title PASSED tests/server/mcpserver/test_title.py::test_resource_title PASSED tests/server/mcpserver/test_title.py::test_get_display_name_utility PASSED |
Remove duplicate title check by moving universal title-first logic outside the isinstance(Tool) conditional. This improves readability and maintainability while preserving all existing behavior.
Fixes #3480
Fixes #
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
help wanted, or I'm a maintainer)Additional context