Skip to content

fix(tests): remove xfail from test_build_metadata simple-url case - #3535

Closed
KhaledDab wants to merge 1 commit into
modelcontextprotocol:mainfrom
KhaledDab:fix/test-build-metadata-xfail
Closed

KhaledDab wants to merge 1 commit into
modelcontextprotocol:mainfrom
KhaledDab:fix/test-build-metadata-xfail

Conversation

@KhaledDab

Copy link
Copy Markdown

The xfail blamed a Pydantic bug about trailing slashes, but the real issue was that AnyHttpUrl('https://auth.example.com') normalizes the URL to 'https://auth.example.com/' at construction time. Once built, passing that object to a model with url_preserve_empty_path=True has no effect — the config only applies when parsing from a string.

Fix: construct test inputs via TypeAdapter(AnyHttpUrl, config=ConfigDict(url_preserve_empty_path=True)).validate_python(), which mirrors how AuthSettings parses issuer_url in production and preserves the empty path correctly end to end.

Fixes #

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I am assigned to the linked issue (or it is labeled help wanted, or I'm a maintainer)
  • I have disclosed any AI assistance and can explain the change in my own words
  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

The xfail blamed a Pydantic bug about trailing slashes, but the real
issue was that AnyHttpUrl('https://auth.example.com') normalizes the
URL to 'https://auth.example.com/' at construction time. Once built,
passing that object to a model with url_preserve_empty_path=True has
no effect — the config only applies when parsing from a string.

Fix: construct test inputs via TypeAdapter(AnyHttpUrl,
config=ConfigDict(url_preserve_empty_path=True)).validate_python(),
which mirrors how AuthSettings parses issuer_url in production and
preserves the empty path correctly end to end.
@github-actions github-actions Bot added the missing-issue-link Auto-closed: PR needs a linked issue assigned to its author (see CONTRIBUTING.md) label Sep 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and this PR doesn't link an open issue yet.

  • If you're already assigned to an issue for this, add Fixes #<n> to the description and the PR will reopen on its own.
  • If there's no issue yet, please open one instead: what you ran into, why it matters for your use case, and a minimal reproduction. That context is super important to us and is what we use to decide what to prioritise.
  • If there's an issue but you're not assigned, add Fixes #<n> anyway so they're linked, then engage on the issue itself by confirming the repro or describing the approach you'd take. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. If you are assigned, this PR reopens automatically.

You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way.

CONTRIBUTING.md has the full reasoning, but in short:

  • We're a small team with very little capacity to review community PRs right now.
  • Many recent PRs are AI-generated with little human review, and reviewing one carefully still costs a maintainer as much time as it ever did. A well-described issue is usually more useful to us than the code.

Maintainers: reopen, remove missing-issue-link, or add bypass-issue-check to override.

@github-actions github-actions Bot closed this Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-issue-link Auto-closed: PR needs a linked issue assigned to its author (see CONTRIBUTING.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant