fix(client/oauth): preserve token endpoint error diagnostics - #549
Merged
koic merged 1 commit intoSep 14, 2026
Merged
Conversation
koic
reviewed
Sep 10, 2026
koic
reviewed
Sep 10, 2026
koic
reviewed
Sep 10, 2026
Member
|
@junyuanz1 ping. |
Contributor
Author
|
@koic updated :) sorry missed the email notificatoin on Friday |
Member
|
@junyuanz1 Looks good to me. Can you squash your commits into one? |
junyuanz1
force-pushed
the
fix/oauth-token-error-diagnostics
branch
from
September 14, 2026 13:47
64d75c6 to
8d1d5be
Compare
Contributor
Author
|
@koic done :) |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Token endpoint failures currently discard the OAuth error description, leaving callers with only an HTTP status. For example, Notion's
invalid_requestresponse explaining that a client used multiple authentication methods becomes onlyToken endpoint returned status 400., forcing callers to replay the request to diagnose it.Preserve RFC 6749 §5.2
erroranderror_descriptionin the exception message and exposehttp_status,error, anderror_descriptionreaders. KeepInvalidGrantErrorclassification and refresh recovery behavior unchanged. Malformed responses retain the status-only fallback.Only the two diagnostic fields are included; other response fields and the raw body are excluded. Normalize text to the RFC's printable ASCII set and cap error codes at 128 characters and descriptions at 512. Document that provider-controlled descriptions may still contain sensitive information and require application logging policies.
Validation:
git diff --checkpassed.