Conversation
DaleSeo
force-pushed
the
DaleSeo/streamable-http-server-duplicate-sep-2243-header
branch
from
September 15, 2026 15:23
f985b6a to
6e33ca0
Compare
DaleSeo
marked this pull request as ready for review
September 15, 2026 15:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1272.
Motivation and Context
For SEP-2243, header validation used
HeaderMap::getto read each header. That method returns only the first of several field lines with the same name. As a result, a request with two conflictingMcp-Methodvalues was validated against the first value, while the second was silently ignored.header_strnow returnsResult<Option<&str>, String>and rejects duplicate field lines. This handlesMcp-Method,Mcp-Name, andMcp-Param-*in one place.How Has This Been Tested?
Added tests
Breaking Changes
None
Types of changes
Checklist