Skip to content

[v1.x] fix(shared): stop referencing the DOM-only global HeadersInit in normalizeHeaders #2807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nikolas-sapa wants to merge 4 commits into
base: v1.x
Choose a base branch
from
+9 −3
Open

[v1.x] fix(shared): stop referencing the DOM-only global HeadersInit in normalizeHeaders #2807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
01a7a05
fix(shared): stop referencing the DOM-only global HeadersInit in norm…
nikolas-sapa Sep 13, 2026
ca6af4a
style: format changeset with prettier
nikolas-sapa Sep 13, 2026
c284f7e
chore: remove pnpm workspace artifact from local install
nikolas-sapa Sep 13, 2026
cb54794
chore: remove local lockfile artifact
nikolas-sapa Sep 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/normalize-headers-node-consumers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@modelcontextprotocol/sdk': patch
---

`normalizeHeaders` no longer references the DOM-only global `HeadersInit` in its published declaration. It now uses `RequestInit['headers']`, which `@types/node` binds globally, so Node-only consumers compiling with `skipLibCheck: false` and no `"DOM"` lib no longer fail with
`TS2304: Cannot find name 'HeadersInit'`. Fixes #2568
6 changes: 3 additions & 3 deletions src/shared/transport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ import { JSONRPCMessage, MessageExtraInfo, RequestId } from '../types.js';
export type FetchLike = (url: string | URL, init?: RequestInit) => Promise<Response>;

/**
* Normalizes HeadersInit to a plain Record<string, string> for manipulation.
* Handles Headers objects, arrays of tuples, and plain objects.
* Normalizes header init (Headers instance, array of tuples, or plain object)
* to a plain Record<string, string> for manipulation.
*/
export function normalizeHeaders(headers: HeadersInit | undefined): Record<string, string> {
export function normalizeHeaders(headers: RequestInit['headers'] | undefined): Record<string, string> {
if (!headers) return {};

if (headers instanceof Headers) {
Expand Down
Loading