Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
After a search populates the skill index, disabling or removing all
skills leaves stale search results.
_ensure_indexed()skips indexingwhen there are no documents but still updates the cache version.
Reset the retriever when there are no enabled skill documents.
Add regression tests covering:
Validation
tests/skills/test_skill_features.pypass with the fix.git diff --checkpasses.Full-repository checks and remote CI have not been run.
Implementation and regression tests were prepared with AI assistance.
Related issue number
Fixes #974
Checklist
pre-commit installandpre-commit run --all-filesbefore git commit, and passed lint check.Pre-commit was run on the two changed files; the full-repository
checklist item remains unchecked. No documentation changes are needed
for this internal bug fix.