Skip to content

feat(ui): add support line number in "Open file in editor" for zed - #1073

Open
seiichi1101 wants to merge 1 commit into
modem-dev:mainfrom
seiichi1101:feat/open-in-editor-zed-line
Open

feat(ui): add support line number in "Open file in editor" for zed#1073
seiichi1101 wants to merge 1 commit into
modem-dev:mainfrom
seiichi1101:feat/open-in-editor-zed-line

Conversation

@seiichi1101

@seiichi1101 seiichi1101 commented Sep 9, 2026

Copy link
Copy Markdown

Summary

When $EDITOR is Zed, pressing e opens the correct file but does not jump to the selected line.
Zed accepts path:line (its CLI help documents path:line:column), so this passes the line number the same way #496 did for Helix.

Changes

  • buildEditorCommand(): handle zed and zeditor (Linux distro package CLI name) with ${filePath}:${line}
  • One test covering zed --wait (path:line plus preserved flags) and zeditor; the existing "unknown editor" test example moves from zed --new-window to a neutral placeholder since Zed is no longer unknown
  • Changeset entry (patch)

Verification

  • bun test packages/hunk/src/ui/lib/openInEditor.test.ts (19 pass), bun run typecheck, bun run lint, bun run format:check, bun run deps:check all pass
  • bun run test: 4 failures remain in test/cli (HUNK_NODE_ADAPTER_BUNDLE not built, --watch from local user config, local git log date format). They reproduce identically on main with bun test test/cli test/session and are unrelated to this change.
  • zed --help (Linux, Zed CLI) confirms [PATHS_WITH_POSITION]... with path:line:column syntax. Not manually exercised in the TUI.

Related: #310 (original e shortcut), #496 (Helix line support)

🤖 Generated with Claude Code

@greptile-apps

greptile-apps Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

PR author is not in the allowed authors list.

@vercel

vercel Bot commented Sep 9, 2026

Copy link
Copy Markdown

@seiichi1101 is attempting to deploy a commit to the Modem Team on Vercel.

A member of the Team first needs to authorize it.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@seiichi1101
seiichi1101 force-pushed the feat/open-in-editor-zed-line branch from fef3a08 to 6c0b097 Compare September 9, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant