feat(ui): add support line number in "Open file in editor" for zed - #1073
Open
seiichi1101 wants to merge 1 commit into
Open
feat(ui): add support line number in "Open file in editor" for zed#1073seiichi1101 wants to merge 1 commit into
seiichi1101 wants to merge 1 commit into
Conversation
Contributor
|
PR author is not in the allowed authors list. |
|
@seiichi1101 is attempting to deploy a commit to the Modem Team on Vercel. A member of the Team first needs to authorize it. |
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
seiichi1101
force-pushed
the
feat/open-in-editor-zed-line
branch
from
September 9, 2026 12:57
fef3a08 to
6c0b097
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
$EDITORis Zed, pressingeopens the correct file but does not jump to the selected line.Zed accepts
path:line(its CLI help documentspath:line:column), so this passes the line number the same way #496 did for Helix.Changes
buildEditorCommand(): handlezedandzeditor(Linux distro package CLI name) with${filePath}:${line}zed --wait(path:line plus preserved flags) andzeditor; the existing "unknown editor" test example moves fromzed --new-windowto a neutral placeholder since Zed is no longer unknownpatch)Verification
bun test packages/hunk/src/ui/lib/openInEditor.test.ts(19 pass),bun run typecheck,bun run lint,bun run format:check,bun run deps:checkall passbun run test: 4 failures remain intest/cli(HUNK_NODE_ADAPTER_BUNDLEnot built,--watchfrom local user config, localgit logdate format). They reproduce identically onmainwithbun test test/cli test/sessionand are unrelated to this change.zed --help(Linux, Zed CLI) confirms[PATHS_WITH_POSITION]...withpath:line:columnsyntax. Not manually exercised in the TUI.Related: #310 (original
eshortcut), #496 (Helix line support)🤖 Generated with Claude Code