chore(ci): run the dependency check daily instead of weekly - #233
Merged
Merged
Conversation
This was referenced Sep 20, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
_checks.ymlalready documents the hazard for the floors job: a release published upstream today"can turn it red for reasons no PR here caused", which is why that job is off for pull requests and
runs from
scheduled.yml, where a failure opens a tracking issue rather than blocking a merge.Newest resolution has the same hazard and none of that protection. Nothing here is pinned, so it is
equally exposed, and it runs on every pull request via
ci.yml.That is what happened on Saturday. faststream 0.7.6 published at 09:27 UTC;
BrokerUsecasegained athird type parameter and
tybegan rejectingRedisBroker.mainhad last been green at 08:42 UTC.The first thing to notice was #231, an unrelated Sentry change, where it looked like the author's
fault. The tracking-issue path never fired, because it only covers the floors job.
The detector was also a week wide:
scheduled.ymlran Mondays 06:00 UTC, so the gap between thatrelease and the next scheduled check was about 44 hours.
The change
One line of cadence, plus the wording that referred to it.
scheduled.ymlcron moves from0 6 * * 1to0 6 * * *.report-scheduled-failure.shno longer calls the check "weekly", in the issue body and in thelabel description.
lowest-direct: trueis unchanged, so the daily run continues to cover both resolutions. No newinputs, no job splitting.
Why this shape
Pinning would remove the ambush entirely, but a committed lock hides upstream breakage instead of
surfacing it, and fresh resolution is deliberately the early-warning system here. So the fix is to
make the warning reach
mainfirst, not to silence it. It bounds the window at roughly a day ratherthan eliminating it, which is the most that is available without pinning.
Cost is not a factor: the repository is public, so GitHub-hosted runners are free.
report-scheduled-failure.shalready dedupes (it opens one issue per failure streak and comments onit thereafter), so a daily cadence adds a comment per day while something is broken rather than an
issue per day.
Verification
No test covers
.github, so there is no test seam for a cadence change. I parsed the workflow toconfirm the result rather than eyeballing the diff:
bash -non the script passes, andjust lint-ciandjust testare clean (307 passed).Not included
security-audit.ymlstill runs weekly on Mondays. It is a different workflow with a differentpurpose and is out of scope here.
The
lowest-directjob runs onlyscripts/floor_smoke.py, nottyorpytest, so nothing in CIchecks that the three-parameter
BrokerUsecaseannotation typechecks at the declared 0.6 floor. Iverified that by hand when fixing it. Worth a separate decision.