test: drop FromPath so the litestar suite runs at its declared floor - #246
Merged
Merged
Conversation
This was referenced Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #242.
The floor is not broken; the test was
The issue proposes raising
litestar>=2.19to the release that introducedFromPath. That would bewrong here. Three checks:
FromPathappears only intests/test_litestar_bootstrap.py, never inlite_bootstrap/.--resolution lowest-directandran
LitestarBootstrapper(...).bootstrap()successfully.The declared floor is an honest promise to users. It was a test reaching for sugar the floor does not
have, so the test changed instead. Both usages already declare the type in the route path
(
/items/{item_id:int}), which makesFromPath[int]decoration rather than requirement.One premise in the issue does not hold for this repo
That is the org-wide finding from modern-python/.github#107. This repo already runs a
lowest-directjob: 5 targets x 5 interpreters, installing every declared floor and bootstrapping against it with
scripts/floor_smoke.py. It passes, correctly, because the library really does work at 2.19.What pulling the thread turned up
Running the suite at the floor surfaced 21 failures. They are not what they look like:
the test file assumes a full dev environment (fastapi, faststream, fastmcp) that
litestar-allalone does not install.
Two real bugs came out of it, neither in scope here: the sentry-sdk floor crash fixed in #244 and
released as 1.9.1, and the OpenTelemetry instrumentation floor break filed separately.
Verification
At
--resolution lowest-directwith litestar 2.19.0, the file now imports and collects, where beforethe
ImportErrorfailed the whole module at collection. 324 tests,ruff,tyclean at currentresolution.
Test-only. No production code, no runtime behaviour, floor unchanged.