Skip to content

fix: stress-ng syscall result parse #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Artanias merged 2 commits into from
Aug 14, 2026
Merged

fix: stress-ng syscall result parse #440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2a5c88
fix: stress-ng syscall result parse. No Max for suse for some reason
NikitaKrinkin Aug 13, 2026
353b125
feat: unit test for new syscall parse
NikitaKrinkin Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/imgtests/exec/loaders/stress_ng.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class StressNGResult(NamedTuple):
summary: StressNGSummary | None


SYSCALL_ENTRY_RE: Final = re.compile(r"^syscall:\s+(\S+)\s+([\d.]+)\s+(\d+)\s+(\d+)$")
SYSCALL_ENTRY_RE: Final = re.compile(r"^syscall:\s+(\S+)\s+([\d.]+)\s+(\d+)(?:\s+(\d+))?$")
Comment thread
NikitaKrinkin marked this conversation as resolved.
SPF_RE: Final = re.compile(r"^(skipped|passed|failed):\s*(\d+)(?::\s*([^\s()]+))?", re.IGNORECASE)
METRICS_UNTRUSTY_RE: Final = re.compile(r"metrics untrustworthy:\s*(\d+)", re.IGNORECASE)
CLEAN_LINE_RE: Final = re.compile(r"stress-ng: (?:info|metrc):\s+\[\d+\]\s*")
Expand Down Expand Up @@ -506,7 +506,7 @@ def parse_metrics( # noqa: PLR0915, PLR0912, C901
try:
avg = float(m_syscall.group(2))
mn = int(m_syscall.group(3))
mx = int(m_syscall.group(4))
mx = int(m_syscall.group(4)) if m_syscall.group(4) is not None else -1
except ValueError:
continue
target = current_stressor or "syscall"
Expand Down
78 changes: 78 additions & 0 deletions tests/unit/imgtests/exec/loaders/test_stress_ng.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,82 @@
),
],
),
(
dedent(
"""\
stress-ng: info: [14018] syscall: Top 268 fastest system calls (timings in nanosecs):
stress-ng: info: [14018] syscall: System Call Avg (ns) Min (ns)
stress-ng: info: [14018] syscall: time 2430.0 2430
stress-ng: info: [14018] syscall: getpid 2805.0 2720
stress-ng: info: [14018] syscall: restart_syscall 3305.0 3270
stress-ng: info: [14018] syscall: sched_get_priority_min 3365.0 3090
stress-ng: info: [14018] syscall: clock_gettime 3400.0 3080
stress-ng: info: [14018] syscall: set_robust_list 3825.0 3050
stress-ng: info: [14018] syscall: timer_delete 4200.0 4150
stress-ng: info: [14018] syscall: sched_get_priority_max 4495.0 3900
""",
).strip(),
[
StressNGMetrics(
"syscall",
0,
0.0,
0.0,
0.0,
0.0,
0.0,
0.0,
None,
None,
(
StressNGSyscallTiming("sched_get_priority_max", 4495.0, 3900, -1),
StressNGSyscallTiming("timer_delete", 4200.0, 4150, -1),
StressNGSyscallTiming("set_robust_list", 3825.0, 3050, -1),
StressNGSyscallTiming("clock_gettime", 3400.0, 3080, -1),
StressNGSyscallTiming("sched_get_priority_min", 3365.0, 3090, -1),
StressNGSyscallTiming("restart_syscall", 3305.0, 3270, -1),
StressNGSyscallTiming("getpid", 2805.0, 2720, -1),
StressNGSyscallTiming("time", 2430.0, 2430, -1),
),
),
],
),
(
dedent(
"""\
stress-ng: info: [667] syscall: Top 263 fastest system calls (timings in nanosecs):
stress-ng: info: [667] syscall: System Call Avg (ns) Min (ns) Max (ns)
stress-ng: info: [667] syscall: time 8717.5 1914 15521
stress-ng: info: [667] syscall: gettimeofday 12214.0 2055 22373
stress-ng: info: [667] syscall: setresgid 19381.5 18801 19962
stress-ng: info: [667] syscall: setresuid 20068.0 18851 21285
stress-ng: info: [667] syscall: fcntl 20908.0 19998 21818
stress-ng: info: [667] syscall: getsid 23327.5 22468 24187
""",
).strip(),
[
StressNGMetrics(
"syscall",
0,
0.0,
0.0,
0.0,
0.0,
0.0,
0.0,
None,
None,
(
StressNGSyscallTiming("getsid", 23327.5, 22468, 24187),
StressNGSyscallTiming("fcntl", 20908.0, 19998, 21818),
StressNGSyscallTiming("setresuid", 20068.0, 18851, 21285),
StressNGSyscallTiming("setresgid", 19381.5, 18801, 19962),
StressNGSyscallTiming("gettimeofday", 12214.0, 2055, 22373),
StressNGSyscallTiming("time", 8717.5, 1914, 15521),
),
),
],
),
],
ids=[
"One stressor with old metrics format.",
Expand All @@ -140,6 +216,8 @@
"Two stressors with new metrics format.",
"Syscall with syscall-top and perf entries.",
"Metrics for different subsystems.",
"OpenSUSE slowest syscall parse: no max value os suse.",
"Poky slowest syscall parse.",
],
)
def test_parse_metrics(raw_metrics: str, expected: list[StressNGMetrics]) -> None:
Expand Down
Loading