Skip to content

chore(mongodb-schema): replace @mongodb-js/compass-test-server with an inline mochaTestServer COMPASS-11068 - #861

Merged
nbbeeken merged 1 commit into
mainfrom
COMPASS-11068-test-server
Aug 24, 2026
Merged

chore(mongodb-schema): replace @mongodb-js/compass-test-server with an inline mochaTestServer COMPASS-11068#861
nbbeeken merged 1 commit into
mainfrom
COMPASS-11068-test-server

Conversation

@nbbeeken

Copy link
Copy Markdown
Collaborator

Description

@mongodb-js/compass-test-server has been private for a while now making it no longer update on npm, this package is forever going to pull in an old version of that compass package which uses an old mongodb-runner version making it impossible to remove old "tar" and other such vuln packages from the tree.

This PR now makes mongodb-runner a direct dev dependency and copies the helper function it was using into this repo.

Open Questions

Checklist

Copilot AI lite review requested due to automatic review settings August 24, 2026 17:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the private @mongodb-js/compass-test-server dependency from mongodb-schema tests by inlining the needed Mocha test-server helper and adding mongodb-runner as a direct dev dependency to avoid pulling outdated transitive packages.

Changes:

  • Replaced @mongodb-js/compass-test-server usage with an inline mochaTestServer() helper built on mongodb-runner.
  • Updated packages/mongodb-schema devDependencies to remove @mongodb-js/compass-test-server and add mongodb-runner.
  • Updated the root lockfile to reflect the dependency tree changes.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
packages/mongodb-schema/test/integration/generate-and-validate.test.ts Inlines a Mocha-managed MongoDB standalone startup/teardown helper using mongodb-runner.
packages/mongodb-schema/package.json Swaps dev dependency from @mongodb-js/compass-test-server to mongodb-runner.
package-lock.json Removes @mongodb-js/compass-test-server entries and adds/updates mongodb-runner resolution.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@nbbeeken
nbbeeken enabled auto-merge (squash) August 24, 2026 17:33
@nbbeeken
nbbeeken merged commit fa0d591 into main Aug 24, 2026
20 checks passed
@nbbeeken
nbbeeken deleted the COMPASS-11068-test-server branch August 24, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants