chore(mongodb-schema): replace @mongodb-js/compass-test-server with an inline mochaTestServer COMPASS-11068 - #861
Merged
Merged
Conversation
… an inline `mochaTestServer` COMPASS-11068
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the private @mongodb-js/compass-test-server dependency from mongodb-schema tests by inlining the needed Mocha test-server helper and adding mongodb-runner as a direct dev dependency to avoid pulling outdated transitive packages.
Changes:
- Replaced
@mongodb-js/compass-test-serverusage with an inlinemochaTestServer()helper built onmongodb-runner. - Updated
packages/mongodb-schemadevDependencies to remove@mongodb-js/compass-test-serverand addmongodb-runner. - Updated the root lockfile to reflect the dependency tree changes.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/mongodb-schema/test/integration/generate-and-validate.test.ts | Inlines a Mocha-managed MongoDB standalone startup/teardown helper using mongodb-runner. |
| packages/mongodb-schema/package.json | Swaps dev dependency from @mongodb-js/compass-test-server to mongodb-runner. |
| package-lock.json | Removes @mongodb-js/compass-test-server entries and adds/updates mongodb-runner resolution. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Anemy
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@mongodb-js/compass-test-serverhas been private for a while now making it no longer update on npm, this package is forever going to pull in an old version of that compass package which uses an old mongodb-runner version making it impossible to remove old "tar" and other such vuln packages from the tree.This PR now makes mongodb-runner a direct dev dependency and copies the helper function it was using into this repo.
Open Questions
Checklist