PYTHON-5290 - Align client bulkwrite prose test with spec - #3009
Open
NoahStapp wants to merge 2 commits into
Open
PYTHON-5290 - Align client bulkwrite prose test with spec#3009NoahStapp wants to merge 2 commits into
NoahStapp wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns the Client-Side Operations Timeout (CSOT) prose test test_timeout_in_multi_batch_bulk_write with the CSOT specification requirement that it only run against standalone topologies, preventing it from running in unsupported environments.
Changes:
- Restrict
test_timeout_in_multi_batch_bulk_writeto standalone topology viarequire_standalone(sync + async variants). - Remove the prior
@flaky(...)decorator from that test (sync + async variants).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/test_client_bulk_write.py | Adds @client_context.require_standalone to the CSOT multi-batch bulk write timeout test (sync). |
| test/asynchronous/test_client_bulk_write.py | Adds @async_client_context.require_standalone to the same CSOT test (async). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
631
to
634
| @client_context.require_version_min(8, 0, 0, -24) | ||
| @client_context.require_failCommand_fail_point | ||
| @flaky(reason="PYTHON-5290", max_runs=3, affects_cpython_linux=True) | ||
| @client_context.require_standalone | ||
| def test_timeout_in_multi_batch_bulk_write(self): |
Comment on lines
635
to
638
| @async_client_context.require_version_min(8, 0, 0, -24) | ||
| @async_client_context.require_failCommand_fail_point | ||
| @flaky(reason="PYTHON-5290", max_runs=3, affects_cpython_linux=True) | ||
| @async_client_context.require_standalone | ||
| async def test_timeout_in_multi_batch_bulk_write(self): |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-5290
Changes in this PR
The
test_timeout_in_multi_batch_bulk_writemust only be run against standalone topologies according to the spec, but we currently apply no such limitation. This PR aligns us with the spec.
Test Plan
N/A
Checklist
Checklist for Author
Checklist for Reviewer