Skip to content

PYTHON-5300 - Fix unraisable error failure for test_infinite_loop_exc… #3010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NoahStapp merged 1 commit into from
Aug 27, 2026
+20 −6
Merged

PYTHON-5300 - Fix unraisable error failure for test_infinite_loop_exc… #3010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions test/asynchronous/test_custom_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
from __future__ import annotations

import datetime
import gc
import sys
import tempfile
from collections import OrderedDict
Expand Down Expand Up @@ -427,9 +428,15 @@ def test_infinite_loop_exceeds_max_recursion_depth(self):
type_registry=TypeRegistry([self.B2A()], fallback_encoder=self.fallback_encoder_A2B)
)

# Raises max recursion depth exceeded error
with self.assertRaises(RuntimeError):
encode({"x": self.TypeA(100)}, codec_options=codecopts)
# GC while the stack is exhausted may trigger an unraisable RecursionError that causes a failure
gc.collect()
gc.disable()
try:
# Raises max recursion depth exceeded error
with self.assertRaises(RuntimeError):
encode({"x": self.TypeA(100)}, codec_options=codecopts)
finally:
gc.enable()
Comment thread
NoahStapp marked this conversation as resolved.


class TestTypeRegistry(unittest.TestCase):
Expand Down
13 changes: 10 additions & 3 deletions test/test_custom_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
from __future__ import annotations

import datetime
import gc
import sys
import tempfile
from collections import OrderedDict
Expand Down Expand Up @@ -427,9 +428,15 @@ def test_infinite_loop_exceeds_max_recursion_depth(self):
type_registry=TypeRegistry([self.B2A()], fallback_encoder=self.fallback_encoder_A2B)
)

# Raises max recursion depth exceeded error
with self.assertRaises(RuntimeError):
encode({"x": self.TypeA(100)}, codec_options=codecopts)
# GC while the stack is exhausted may trigger an unraisable RecursionError that causes a failure
gc.collect()
gc.disable()
try:
# Raises max recursion depth exceeded error
with self.assertRaises(RuntimeError):
encode({"x": self.TypeA(100)}, codec_options=codecopts)
finally:
gc.enable()
Comment thread
NoahStapp marked this conversation as resolved.


class TestTypeRegistry(unittest.TestCase):
Expand Down
Loading