Skip to content

PYTHON-6002 - Increase failpoint times for test_heartbeat_awaited_flag - #3011

Merged
NoahStapp merged 1 commit into
mongodb:mainfrom
NoahStapp:PYTHON-6002
Aug 28, 2026
Merged

PYTHON-6002 - Increase failpoint times for test_heartbeat_awaited_flag#3011
NoahStapp merged 1 commit into
mongodb:mainfrom
NoahStapp:PYTHON-6002

Conversation

@NoahStapp

Copy link
Copy Markdown
Contributor

PYTHON-6002

Changes in this PR

The test_heartbeat_awaited_flag test can fail on slower hosts due to the changes in SERVER-128517. This PR increases the number of times the test's failpoint triggers to eliminate those possible failures.

Test Plan

Test changes.

Checklist

Checklist for Author

  • Did you update the changelog (if necessary)?
  • Is there test coverage?
  • Is any followup work tracked in a JIRA ticket? If so, add link(s).

Checklist for Reviewer

  • Does the title of the PR reference a JIRA Ticket?
  • Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?)
  • Is all relevant documentation (README or docstring) updated?

Copilot AI lite review requested due to automatic review settings August 27, 2026 14:29
@NoahStapp
NoahStapp requested a review from a team as a code owner August 27, 2026 14:29
@NoahStapp
NoahStapp requested a review from sleepyStick August 27, 2026 14:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the heartbeat failpoint configuration used by test_heartbeat_awaited_flag to reduce flakiness on slower hosts (per PYTHON-6002), by ensuring the failCommand failpoint does not exhaust its trigger count before a delayed heartbeat occurs.

Changes:

  • Increase the failCommand failpoint trigger count from 2 to 4 in test_heartbeat_awaited_flag.
  • Apply the same change to both the asynchronous and synchronous variants of the streaming protocol test.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
test/test_streaming_protocol.py Increases the failpoint "mode.times" for the synchronous test_heartbeat_awaited_flag to reduce timing-related flakiness.
test/asynchronous/test_streaming_protocol.py Increases the failpoint "mode.times" for the async test_heartbeat_awaited_flag to reduce timing-related flakiness.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@NoahStapp
NoahStapp merged commit 4ce7355 into mongodb:main Aug 28, 2026
88 of 90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants