Skip to content

Rename module to module_ for C++20 compatibility #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhaschke merged 1 commit into from
Jul 14, 2026
Merged

Rename module to module_ for C++20 compatibility #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions include/py_binding_tools/ros_msg_typecasters.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ struct type_caster<rclcpp::Time>
// convert from rclcpp::Time to rclpy::Time
static handle cast(const rclcpp::Time& src, return_value_policy /* policy */, handle /* parent */)
{
object Time = module::import("rclpy.time").attr("Time");
object Time = module_::import("rclpy.time").attr("Time");
object ClockType = Time().attr("clock_type").attr("__class__");

return Time(arg("nanoseconds") = src.nanoseconds(),
Expand Down Expand Up @@ -131,7 +131,7 @@ struct RosMsgTypeCaster
object cls = py_binding_tools::createMessageClass(rosidl_generator_traits::name<T>());

// deserialize into python object
module rclpy = module::import("rclpy.serialization");
module_ rclpy = module_::import("rclpy.serialization");
object msg = rclpy.attr("deserialize_message")(buf, cls);

return msg.release();
Expand All @@ -145,7 +145,7 @@ struct RosMsgTypeCaster
return false;

// serialize src into python buffer
module rclpy = module::import("rclpy.serialization");
module_ rclpy = module_::import("rclpy.serialization");
bytes buf = rclpy.attr("serialize_message")(src);

// deserialize into C++ object
Expand Down
Loading