Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for LoRA adapters and closes #18. If there is anything that I should modify or change on this just let me know!
Changes
The main items that I have added on this PR are:
LoraAdapterConfig(path,scale) andModelConfig::loras(std::vector<LoraAdapterConfig>) for configuring one or more adapters.Model::initialize_context()loads and applies LoRA adapters to the model context with individual scaling viallama_set_adapters_lora().Model::get_loras()getter for inspecting loaded adapter pointers.examples/lora/— Example application with documentation for converting adapters and using task prompt templates (including a worked example using IBM Granite RAG query rewriting).tests/test_lora.cpp— unit tests covering config defaults, default scale, and multiple adapter stacking.README.mdupdates documenting LoRA usage and multi-agent context sharing.For testing this locally and interacting with it I used the recommended model (
granite-4.0-micro-Q8_0.gguf) along with a converted Granite query-rewriter LoRA adapter (query_rewrite_lora.gguf).Testing
ctest— all 5 suites pass (ToolTests, CallbacksTests, GrammarTests, LoraTests, ChatParserTests)clang-formatpassesgranite-4.0-micro-Q8_0.gguf+ IBM Granite RAG's query-rewrite LoRA, confirmed the adapter correctly rewrites contextual follow-ups (e.g., "What about Germany?" → "What is the capital of Germany?") that the base model alone does notThanks in advance for the review!!