[AC-154] creates temporary ads client structure AdsStore - #7552
Draft
thesuzerain wants to merge 7 commits into
Draft
[AC-154] creates temporary ads client structure AdsStore#7552thesuzerain wants to merge 7 commits into
AdsStore#7552thesuzerain wants to merge 7 commits into
Conversation
Collaborator
Author
|
Regarding the comment from the other PR @Almaju :
My concern with this is that to store them as
Let me know if I've misunderstood your idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in this PR, this splits out the temporary ads store out of the PR to reduce its complexity.
This is a temporary structure to be used for the first vertical slice of the fire-and-forget refactoring for ads-client. It will be modified in a later PR to use sqlite (durable) instead.
It is currently unused.
I don't think this needs a changelog entry, but the greater fire-and-forget mechanism will include one.
Pull Request checklist
[ci full]to the PR title.