Remove footer Privacy control and trim README - #22
Merged
Conversation
Remove the hidden `#analytics-preferences` "Privacy" button from the footer nav in the generated page shell. `startAnalytics` already guards its lookup with `if (preferences)`, so the analytics module keeps working with the element absent; the consent banner itself is unchanged. Trim the README to what a contributor needs to run and change the site: drop the "Analytics and referrals", "Deploy", and "Search discovery" sections. Add a walkthrough GIF under the website link showing the landing page and four concept pages. Ignore /.claude, which holds local editor and tooling config. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Removed the footer Privacy control —
scripts/build.mjs:180Dropped the
<button id="analytics-preferences" hidden>Privacy</button>from the footer nav in the generated page shell. It appeared on every generated page.Trimmed the README — removed the Analytics and referrals, Deploy, and Search discovery sections, leaving Run locally, AI panel, and Content and checks.
Added a walkthrough GIF —
docs/site-walkthrough.gif(263 KB), embedded under the website link. Shows the landing page followed by the Variables, Functions, Arrow Functions, and Closures pages.Ignored
/.claude— local editor and tooling config, alongside the existing/.vscodeentry.Why
Requested cleanup: the Privacy control and those README sections were no longer wanted, and the README needed a visual of the site.
Reviewer notes
Two consequences of removing the button that are not addressed in this PR, and may want a follow-up:
scripts/build.mjs:187still reads "Change your choice anytime under Privacy," which no longer refers to anything.Separately, the removed README prose was the only documentation of the GA4/PostHog configuration and the
npm run indexnowstep. Both still exist in the code (src/analytics-config.js,src/search-config.js,scripts/submit-indexnow.mjs); only the docs are gone.Testing
node --test test/*.test.mjs— 70/70 pass.src/analytics.js:146already guarded the lookup withif (preferences), so the module works with the element absent. The analytics tests build a synthetic DOM harness rather than parsing the generated HTML, so they were unaffected by the markup change.Verified against a running dev server: the served footer at
/javascript-variables/is now LinkedIn, Contribute on GitHub, Contact, Share. Note the button washiddenon localhost regardless, since analytics only starts on the production hostname allowlist, so the check that matters is the element being gone from the served HTML.The GIF was assembled from headless Chrome screenshots of the local build, not a screen recording, so it has no cursor or click indicators.
🤖 Generated with Claude Code