Let PostHog see that ingestion is proxied - #24
Merged
Conversation
When `api_host` is a custom origin, posthog-js tags every event with `$lib_custom_api_host`, and that property is how the installation health check recognises a reverse proxy. The sanitizer's allowlist dropped it, so the check stayed red even though `/e30` was carrying all the traffic correctly. The value is the site's own public origin, so there is nothing sensitive in letting it through.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #23. The proxy works, but PostHog could not tell.
When
api_hostis a custom origin, posthog-js tags every event with$lib_custom_api_host, and that property is how the installation health check recognises a reverse proxy. The sanitizer's allowlist dropped it, so the check would have stayed red forever even though/e30was carrying all the traffic correctly.Confirmed against production: searching a live
$pageviewforapi_hostin the event properties returned "No properties found".The value is the site's own public origin, so there is nothing sensitive in letting it through.