test: add benchmark tests for encode/decode operations - #56
Open
sumanjeet0012 wants to merge 2 commits into
Open
test: add benchmark tests for encode/decode operations#56sumanjeet0012 wants to merge 2 commits into
sumanjeet0012 wants to merge 2 commits into
Conversation
This was referenced Sep 7, 2026
acul71
requested changes
Sep 7, 2026
acul71
left a comment
Contributor
There was a problem hiding this comment.
Review (maintainer)
Thanks for the clean benchmark addition — it matches #42 and the go-multibase encode/decode/roundtrip shape, and local/CI validation looks good once pytest-benchmark is present.
Blocking
Missing newsfragment — this is a mandatory requirement for approval.
Please add something like:
newsfragments/42.misc.rst(or42.internal.rst)
with a short ReST line describing the change for HISTORY, ending with a trailing newline. Example:
Added pytest-benchmark encode/decode/roundtrip benchmarks covering all multibase encodings.Non-blocking but important
- Branch is 6 commits behind
master— please rebase (or merge) onto currentorigin/masterbefore landing. - CI cost: these benchmarks run in the normal pytest suite (~40s+ locally for 72 timed cases). Consider default-disabling them in regular CI (
--benchmark-disable/ config) and documenting how to run them explicitly, unless we intentionally want always-on timings. pyproject.tomloverlap with open PRs #49 and #57 — informational only; expect a trivial dependency-list conflict when those merge.
Full structured review saved locally as AI-PR-REVIEW-56-0.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42
Description
This pull request adds benchmark tests for all encodings to establish performance baselines and help catch regressions. Similar to the benchmarks in
go-multibase(BenchmarkEncode,BenchmarkDecode,BenchmarkRoundTrip), these benchmark tests run across all supported implementations.Changes
pytest-benchmarkas a development dependency inpyproject.toml.tests/test_benchmarks.pycontainingtest_bench_encode,test_bench_decode, andtest_bench_roundtripparameterized across allENCODINGS.