Update quinn-proto to 0.11.15 and add lockfile regression test - #1261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
quinn-protolockfile entry to a patched 0.11.x release and prevent regressions with an automated test.Description
Cargo.lockto movequinn-protofrom0.11.14to0.11.15and recorded the new Cargo checksum generated bycargo update -p quinn-proto --precise 0.11.15without adding a directquinn-protodependency inCargo.toml.reqwest -> quinn -> quinn-prototransitive relationship and did not alterreqwestorquinndeclarations.tests/dependency_security.rs, a lockfile regression test that reads the workspaceCargo.lockviaenv!("CARGO_MANIFEST_DIR"), finds exact[[package]]records namedquinn-proto, parses strictmajor.minor.patchnumeric versions, requires at least one record, and enforces the secure range>= 0.11.15and< 0.12.0.0.11.14, accepting0.11.15and later 0.11.x patches, rejecting malformed/pre-release values, and rejecting an unexpected major/minor bump to0.12.x.Testing
cargo update -p quinn-proto --precise 0.11.15, which completed successfully and updatedCargo.lockwith the new checksum.rustc(CARGO_MANIFEST_DIR="$PWD" rustc --edition=2024 --test tests/dependency_security.rs -o /tmp/dependency_security_test && /tmp/dependency_security_test) and observed both tests passing (2 passed).cargo test --locked --test dependency_securityandcargo build --locked --all-targetsin the CI-like environment was blocked by missing system ALSA development metadata required byalsa-sys(build failure), preventing a full workspace run; the regression test itself passed when run standalone.cargo tree -i quinn-proto --lockedreported no second vulnerablequinn-protoversion in the active resolution for the tested targets, andcargo nextestcould not be executed in the environment becausecargo-nextestwas not installed.Codex Task