✨ Add controlled multiplication modulo N benchmark - #2409
Draft
denialhaag wants to merge 15 commits into
Draft
Conversation
Assisted-by: GPT-5.6 Sol via Codex
Assisted-by: GPT-5.6 Sol via Codex
Assisted-by: GPT-5.6 Sol via Codex
Assisted-by: GPT-5.6 Sol via Codex
Assisted-by: GPT-5.6 Sol via Codex
Assisted-by: GPT-5.6 Sol via Codex
Assisted-by: GPT-5.6 Sol via Codex
Assisted-by: GPT-5.6 Sol via Codex
Assisted-by: GPT-5.6 Sol via Codex
Assisted-by: GPT-5.6 Sol via Codex
Assisted-by: GPT-5.6 Sol via Codex
Assisted-by: GPT-5.6 Sol via Codex
Assisted-by: GPT-5.6 Sol via Codex
denialhaag
force-pushed
the
codex/add-controlled-multiplication-modulo-n
branch
from
September 5, 2026 17:34
83fc28f to
9c5d25f
Compare
12 tasks
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Assisted-by: GPT-5.6 Sol via Codex
Assisted-by: GPT-5.6 Sol via Codex
denialhaag
force-pushed
the
codex/add-classical-qft-adder
branch
from
September 7, 2026 11:43
bdf6b92 to
14f4f76
Compare
burgholzer
force-pushed
the
codex/add-classical-qft-adder
branch
from
September 7, 2026 12:16
14f4f76 to
b4bb2c7
Compare
denialhaag
force-pushed
the
codex/add-classical-qft-adder
branch
from
September 7, 2026 12:54
b4bb2c7 to
8a6a067
Compare
burgholzer
force-pushed
the
codex/add-classical-qft-adder
branch
from
September 7, 2026 12:57
8a6a067 to
b30291a
Compare
denialhaag
force-pushed
the
codex/add-classical-qft-adder
branch
from
September 7, 2026 13:17
b30291a to
77e1d2d
Compare
burgholzer
force-pushed
the
codex/add-classical-qft-adder
branch
from
September 7, 2026 13:43
77e1d2d to
93001d5
Compare
Base automatically changed from
codex/add-classical-qft-adder
to
codex/add-quantum-qft-adder
September 7, 2026 15:07
burgholzer
force-pushed
the
codex/add-quantum-qft-adder
branch
from
September 7, 2026 15:26
ba68e13 to
9761141
Compare
denialhaag
force-pushed
the
codex/add-quantum-qft-adder
branch
from
September 7, 2026 17:08
9761141 to
3339f92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
🤖 AI text below 🤖
Add a controlled multiplication modulo N benchmark based on Figures 5 and 6 of Beauregard's circuit for Shor's algorithm: https://arxiv.org/abs/quant-ph/0205095
Each instance prepares the control and multiplicand registers in a uniform superposition, then conditionally writes
multiplier * multiplicand mod modulusto ann + 1-qubit accumulator. The logical result preserves the control, multiplicand, and accumulator so the analytic reference checks their full correlation.Expose the benchmark through validated C++ and Python APIs, strict instance specifications and manifests, command-line discovery, and structured MLIR generation. The generator retains the modular Fourier-adder schedule, including its multi-controlled phase operations and work-qubit cleanup.
This PR is stacked on #2408.
AI notice
This PR and its contents were created with the assistance of GPT-5.6 Sol via Codex.
Checklist
I have added migration instructions to the upgrade guide (if needed).If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).