feat: add versioned list endpoints (20260427) for transfers and cross-account transfers - #389
Open
gerfboy wants to merge 1 commit into
Open
feat: add versioned list endpoints (20260427) for transfers and cross-account transfers#389gerfboy wants to merge 1 commit into
gerfboy wants to merge 1 commit into
Conversation
gerfboy
requested review from
SandhyaBhatia,
mattnichols,
meotch,
stevecl5 and
tessstoddard
as code owners
September 8, 2026 21:35
…-account transfers Mirrors the payment/recurring-payment 20260427 support (commit e9274f9) for internal transfers and cross-account transfers. - Add list20260427() to TransferBaseAccessor, RecurringTransferBaseAccessor, CrossAccountTransferBaseAccessor, and CrossAccountRecurringTransferBaseAccessor. - Version the GET list endpoints in TransfersController, RecurringTransfersController, CrossAccountTransfersController, and CrossAccountRecurringTransferController via DateVersionedResponse: default -> list(), version 20260427 -> list20260427(). - Transfer variants forward the existing TransferListOptions / RecurringTransferListOptions to both paths; cross-account variants take no options, matching payments. - Add v20260427 controller tests and update existing list tests for the new HttpServletRequest parameter.
gerfboy
force-pushed
the
greg/versioned-list-transfers-cross-account
branch
from
September 8, 2026 21:51
ebf3be1 to
e71c304
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Adds versioned (
v20260427) list endpoints for internal transfers and cross-account transfers, mirroring the existing versioned list support for payments and recurring payments (commite9274f9c).Each affected GET list endpoint now routes through
DateVersionedResponse: the default version continues to call the existinglist()accessor, and version20260427calls a newlist20260427()accessor. The20260427variant reuses the same model (the models already carryrecurringTransferId/recurringCrossAccountTransferId); this change affects which records are returned, not the response shape, so no new model orResourcesregistration is required.Jira: MC-15714
Public API Additions/Changes
New base-accessor methods (each
@GatewayAPI/@API, throwingAccessorMethodNotImplementedExceptionby default):TransferBaseAccessor#list20260427(TransferListOptions)RecurringTransferBaseAccessor#list20260427(RecurringTransferListOptions)CrossAccountTransferBaseAccessor#list20260427()CrossAccountRecurringTransferBaseAccessor#list20260427()Versioned GET list endpoints (default →
list(),version=20260427→list20260427()):GET /users/{userId}/transfersGET /users/{userId}/recurring_transfersGET /users/{userId}/cross_account_transfersGET /users/{userId}/cross_account_transfers/recurring_cross_account_transfersControllers now accept an injected
HttpServletRequestalongside any existing query parameters.Downstream Consumer Impact
Non-breaking. Existing (default-version) clients are unaffected — they continue to hit the same
list()accessor and receive identical responses. Accessor implementations that want the new behavior opt in by overridinglist20260427(); until they do, requestingversion=20260427yieldsAccessorMethodNotImplementedException, consistent with the payments precedent.How Has This Been Tested?
./gradlew check(JDK 21) — full build, all tests, coverage, and static analysis passv20260427tests (one per endpoint) verifying the versioned accessor is invoked for...;version=20260427and the default accessor for the unversioned media typelist20260427for all four accessorsChecklist: