fix(toast): position when closed - #2600
Merged
Merged
Conversation
It adds --closed not --close so the toast has wrong position on mobile. Signed-off-by: Varun Patil <varunpatil@ucla.edu>
pulsejet
force-pushed
the
pulsejet/nav-closed
branch
from
September 8, 2026 02:24
6a6795d to
d6cb246
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2600 +/- ##
=======================================
Coverage 59.86% 59.86%
=======================================
Files 15 15
Lines 461 461
Branches 96 96
=======================================
Hits 276 276
Misses 164 164
Partials 21 21 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
skjnldsv
approved these changes
Sep 8, 2026
Contributor
Author
|
@skjnldsv what's the release cadence? Need a release for this patch |
pulsejet
added a commit
to pulsejet/memories
that referenced
this pull request
Sep 13, 2026
Small NcDialog confirmations went fullscreen on mobile and toasts were offset when navigation is closed. Temporary local overrides until the upstream fixes land. nextcloud-libraries/nextcloud-vue#8956 nextcloud-libraries/nextcloud-dialogs#2600 Signed-off-by: Varun Patil <radialapps@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It adds --closed not --close so the toast has wrong position on mobile.
🤖 AI (if applicable)