fix(dav): keep the latest FilePicker destination - #2611
Open
Daddyoftwins1 wants to merge 1 commit into
Open
Daddyoftwins1 wants to merge 1 commit into
Daddyoftwins1 wants to merge 1 commit into
Conversation
Assisted-by: OpenAI Codex:GPT-5 Signed-off-by: Josh Duffy <118084832+Daddyoftwins1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
While moving a folder in Nextcloud, I selected Photos as the destination, but the picker returned the folder I was already in and displayed the message that the folder was already in that directory.
The problem can happen when directory requests finish out of order. Opening another folder starts a newer DAV listing request, but cancellation does not guarantee that the older request stops immediately. If the older response finishes later, it can replace the active folder information even though the path and button still show the newer destination.
This leaves the displayed destination and the folder returned by the picker out of sync.
Changes
This change:
Related to #2511, which covers the same race-condition area.
Testing
The following focused checks passed:
git diff --checkThe complete repository test suite, a production build and fresh live-instance testing were not performed for this contribution branch.
AI assistance
Development and automated testing of this contribution were assisted by OpenAI Codex using GPT-5.