fix(settings): report failures of the admin email toggle - #2911
Open
solracsf wants to merge 1 commit into
Open
Conversation
`OCP.AppConfig.setValue()` dispatches asynchronously and reports failures through its error callback, never by throwing, so the try/catch around it could not fire. The success toast was shown unconditionally and before the request had even completed - including when it failed outright or when password confirmation was declined. It now uses the success and error callbacks, and rolls the optimistic mutation back when the write does not land, so the toggle keeps matching the server. Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OCP.AppConfig.setValue()dispatches asynchronously and reports failures through itserrorcallback, never by throwing, so thetry/catcharound it could not fire. The success toast was shown unconditionally and before the request had even completed — including when it failed outright, or when password confirmation was declined.Now wired to the
successanderrorcallbacks, with the optimistic mutation rolled back when the write doesn't land so the toggle keeps matching the server.