Skip to content

Show only offline-available actions when offline in the "create new" menu #17604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daniele-verducci wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −9
Open

Show only offline-available actions when offline in the "create new" menu #17604

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e7027b
Show only offline-available actions when offline, and align shown act…
daniele-verducci Sep 10, 2026
6a40788
Fixed edge case
daniele-verducci Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions app/src/main/java/com/owncloud/android/ui/fragment/OCFileListBottomSheetDialog.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,18 +419,14 @@ class OCFileListBottomSheetDialog(
}

private fun filterActionsForOfflineOperations() {

@alperozturk96 alperozturk96 Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use suspend functions.

private fun filterActionsForOfflineOperations() {
        lifecycleScope.launch {
            val available = fileActivity.connectivityService.isNetworkAndServerAvailableSuspended()
            if (available && (!file.isOfflineOperation || file.isRootDirectory)) {
                return@launch
            }
            hideCreationOptions()
        }
    }
    
    private suspend fun hideCreationOptions() = withContext(Dispatchers.Main) {
        binding.run {
            menuCreateRichWorkspace.visibility = View.GONE
            creatorsOverviewContainer.visibility = View.GONE
            menuEncryptedMkdir.visibility = View.GONE
        }
    }

fileActivity.connectivityService.isNetworkAndServerAvailable { result: Boolean? ->
if (file.isRootDirectory) {
return@isNetworkAndServerAvailable
}

if (!result!! || file.isOfflineOperation) {
fileActivity.connectivityService.isNetworkAndServerAvailable { available: Boolean? ->
// root directory doesn't have a remote_id and thus always reports as offlineOperation
val isOfflineOperation = file.isOfflineOperation && !file.isRootDirectory
if (available != true || isOfflineOperation) {
binding.run {
menuCreateRichWorkspace.visibility = View.GONE
menuUploadFromApp.visibility = View.GONE
menuDirectCameraUpload.visibility = View.GONE
menuScanDocUpload.visibility = View.GONE
creatorsOverviewContainer.visibility = View.GONE
menuEncryptedMkdir.visibility = View.GONE
}
}
}
Expand Down
Loading