perf(startup): splash screen - #17657
alperozturk96 wants to merge 2 commits into
Conversation
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
|
/backport to stable-35.0.x |
| companion object { | ||
| const val SPLASH_DURATION = 1500L | ||
| private val SPLASH_DURATION = 1500.milliseconds | ||
| private val NO_SPLASH_DURATION = 100.milliseconds |
There was a problem hiding this comment.
100 ms needed so that we can show app icon.
📱 QA build
The QA build installs alongside a released Nextcloud app, so you can keep Downloading the file requires a GitHub account, so open this link on the |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
jancborchardt
left a comment
There was a problem hiding this comment.
Very nice! Can we get it even faster? :)
This is just the beginning. After this PR, I’ll investigate the internal state changes between the loading and loaded states. The splash screen can be faster for the non-branded flow around 1.4 seconds. For the branded flow, it will remain the same so that the custom logo and other branding elements can be displayed. Do you think 1.5 seconds is enough for the branded flow? I would suggest setting it to 300 ms for the branded flow and 100 ms for the non-branded flow. |
Changes
1400 ms faster cold start
Before
Screen_recording_20260916_133720.webm
After
Screen_recording_20260916_133829.webm